Skip to content

Scrollbars class names#88

Open
qodunpob wants to merge 1 commit into
souhe:masterfrom
qodunpob:scrollbars-class-names
Open

Scrollbars class names#88
qodunpob wants to merge 1 commit into
souhe:masterfrom
qodunpob:scrollbars-class-names

Conversation

@qodunpob

Copy link
Copy Markdown

In some cases the best way to customize scrollbars is an class names. That's why I'm added 4 new props:

  • verticalContainerClassName;
  • verticalScrollbarClassName;
  • horizontalContainerClassName;
  • horizontalScrollbarClassName.

I'm also included classnames package for easier manipulation of class names. And wrote the relevant tests.

@qodunpob qodunpob mentioned this pull request Apr 12, 2017
@maximkoretskiy

Copy link
Copy Markdown
Contributor

Duplicate for #62.

@qodunpob

Copy link
Copy Markdown
Author

Sorry, I did not see that pull request. But my decision is different. I propose a separate customization for vertical and horizontal scrollbar. And wrote the relevant tests.

@maximkoretskiy

Copy link
Copy Markdown
Contributor

Ok. But in fact it does not matter. Repo owner does not watch for PR

@souhe

souhe commented Jul 5, 2018

Copy link
Copy Markdown
Owner

Hey, sorry I wasn't watching.
@bashkos could you elaborate more why you think that separating vertical and horizontal classnames is neccessery? What are the usecases? @maximkoretskiy @avanes which solution you prefer? I'm asking because of similar PR #62

@qodunpob

Copy link
Copy Markdown
Author

@souhe
Is not actual for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants