fix: don't wait forever for a child that ignores SIGTERM - #648
Open
ykhrustalev wants to merge 1 commit into
Open
ykhrustalev wants to merge 1 commit into
ykhrustalev wants to merge 1 commit into
Conversation
On a timeout, terminate_child() sent one SIGTERM and then blocked in wait() with no bound. A cargo process that ignores the signal, or that has been stopped and so never receives it, hung the whole run at that point. Wait only for a short grace period, then SIGKILL the process group. This needs a second signal, so the errno handling moves into a signal_group() helper rather than being duplicated.
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a timeout,
terminate()sends oneSIGTERMand then blocks inwait()with no bound. A cargo process that ignores the signal, or that has been stopped and so never receives it, hangs the whole run at that point.Solution
SIGTERM, thenSIGKILLs the process group.killpgerrno handling into asignal_group()helper, since two signals are now sent.Testing
SIGTERM, which cargo doesn't do in normal operation (it is reachable viaSIGSTOP).Split out of #647 as requested. This is the first of a series and stands on its own; next in the stack: #650 (process-group sweep) → #652 (report why a scenario died).