Skip to content

feat(cache): add sequelize support#2554

Open
Sourav-kashyap wants to merge 1 commit into
masterfrom
GH-2552
Open

feat(cache): add sequelize support#2554
Sourav-kashyap wants to merge 1 commit into
masterfrom
GH-2552

Conversation

@Sourav-kashyap

Copy link
Copy Markdown
Contributor

GH-2552

Description

Added Sequelize support to the cache package

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • Code conforms with the style guide
  • API Documentation in code was updated

@Sourav-kashyap Sourav-kashyap requested review from a team and samarpan-b as code owners May 28, 2026 08:16
@Sourav-kashyap Sourav-kashyap linked an issue May 28, 2026 that may be closed by this pull request
@Sourav-kashyap Sourav-kashyap force-pushed the GH-2552 branch 6 times, most recently from eee3c4b to 4148390 Compare May 29, 2026 11:38
@Sourav-kashyap Sourav-kashyap requested a review from rashisf June 12, 2026 11:46
this.bind(HelmetSecurityBindings.CONFIG).to({
frameguard: {action: process.env.X_FRAME_OPTIONS},
frameguard: {
action: process.env.X_FRAME_OPTIONS as

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this part of the cache support that you added

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this changes wasn't part of the cache support. this changes for TypeScript/ESLint type-safety issue where process.env.X_FRAME_OPTIONS is typed as string | undefined, but frameguard.action expects 'deny' | 'sameorigin' | undefined.

@Sourav-kashyap Sourav-kashyap requested a review from rashisf June 22, 2026 06:47
@sonarqubecloud

Copy link
Copy Markdown

SonarQube reviewer guide

Summary: Add Sequelize-based caching support with comprehensive documentation and improved package exports.

Review Focus:

  • The new SequelizeCacheMixin implementation mirrors the existing CacheMixin but targets SequelizeCrudRepository. Verify the mixin correctly handles Sequelize-specific method signatures and that the cache invalidation decorator is properly applied to all write operations.
  • Package export configuration in package.json enables conditional imports (@sourceloop/cache/sequelize). Confirm the export paths correctly resolve to compiled artifacts.
  • Minor refactoring in addTagsToOptions uses nullish coalescing—ensure this maintains backward compatibility.

Start review at: packages/cache/src/mixins/sequelize/cache.mixin.ts. This is the core addition providing Sequelize repository caching and should be thoroughly validated for correctness before approving the feature.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
66.1% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add Sequelize support

2 participants