update helm-doc binary version#777
Closed
DaedalusG wants to merge 1 commit into
Closed
Conversation
michaellzc
approved these changes
Dec 2, 2025
Contributor
Author
|
closing this PR since it would ultimately create an implicit versioning contract with the releaseworker service that the library code it uses is on the same version as the tool call here in the deploy repo 😢 Instead I'll investigate packaging the binary into the releaseworker msp service base image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs updated in order for me to successfully run the
sg release createtemporal workflow for this repo. Working on that here: https://github.com/sourcegraph/sourcegraph/pull/7972If I try to run the helm doc generation in the workflow I can't run a binary (this is a limitation or the temporal machine env which would need access the repo itself to run the binary.) To get around this issue I'm importing libraries that underly the helm-doc binary, but those libraries are built in a different version that helmdocs 1.7 and this is causing CI to fail https://buildkite.com/sourcegraph/deploy-sourcegraph-helm/builds/2379#019ade4b-d69f-42f0-850e-ed1ffdaaa0fd
The capital casing reflects a change in the publishers filename convention
Test plan
tested locally