WIP underflow fixes#1059
Draft
keegancsmith wants to merge 2 commits into
Draft
Conversation
Compound shards can preserve enough table shape to load while still having rune-end offsets that do not map back to the file content boundaries used for slicing. That leaves the first visible failure to happen much later during matching, where the corrupted offset is harder to diagnose and may panic.\n\nValidate the content and filename rune boundary maps at shard load time so bad shards fail with a corruption error at the source of the invariant violation. Amp-Thread-ID: https://ampcode.com/threads/T-019e1c72-ee98-721f-a530-aa1de8d8ef65 Co-authored-by: Amp <amp@ampcode.com>
A corrupt rune-to-byte mapping can make offset lookup land outside the current file. Letting that value underflow or flow into candidate content slicing turns an index invariant violation into a search-time panic.\n\nKeep offset conversion within the current file's byte range and make candidate verification treat out-of-bounds offsets as non-matches, so corrupted shards fail safely instead of crashing while matching. Amp-Thread-ID: https://ampcode.com/threads/T-019e1c72-ee98-721f-a530-aa1de8d8ef65 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.