Add a non-circular shared ref compile benchmark #579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Augment PR SummarySummary: Adds a new micro-benchmark to stress Blaze compilation on a non-circular but highly shared Changes:
Technical Notes: The instrumentation reports to stderr and runs on every compile invocation, including bundle/frame analysis and static-reference precompilation planning. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bindings (linux/nodejs)
Details
| Benchmark suite | Current: 0db1303 | Previous: 9334210 | Ratio |
|---|---|---|---|
E2E_Parse_BlazeJSON_ui5_manifest |
111 ops/sec (±0.38%) |
112 ops/sec (±0.37%) |
1.01 |
E2E_Parse_JSON_ui5_manifest |
792 ops/sec (±0.74%) |
796 ops/sec (±0.41%) |
1.01 |
E2E_Evaluator_adaptivecard |
13408 ops/sec (±0.10%) |
13703 ops/sec (±0.22%) |
1.02 |
E2E_Evaluator_ansible_meta |
1844 ops/sec (±0.44%) |
1857 ops/sec (±0.20%) |
1.01 |
E2E_Evaluator_aws_cdk |
2723 ops/sec (±0.47%) |
2728 ops/sec (±0.14%) |
1.00 |
E2E_Evaluator_babelrc |
1525 ops/sec (±0.11%) |
1522 ops/sec (±0.38%) |
1.00 |
E2E_Evaluator_clang_format |
5077 ops/sec (±0.79%) |
5082 ops/sec (±0.82%) |
1.00 |
E2E_Evaluator_cmake_presets |
142 ops/sec (±1.35%) |
167 ops/sec (±0.14%) |
1.18 |
E2E_Evaluator_code_climate |
562 ops/sec (±0.14%) |
565 ops/sec (±0.08%) |
1.01 |
E2E_Evaluator_cql2 |
2727 ops/sec (±0.40%) |
2752 ops/sec (±0.48%) |
1.01 |
E2E_Evaluator_cspell |
779 ops/sec (±0.17%) |
789 ops/sec (±0.11%) |
1.01 |
E2E_Evaluator_cypress |
1241 ops/sec (±1.16%) |
1223 ops/sec (±0.99%) |
0.99 |
E2E_Evaluator_deno |
967 ops/sec (±0.17%) |
983 ops/sec (±0.15%) |
1.02 |
E2E_Evaluator_dependabot |
846 ops/sec (±0.71%) |
844 ops/sec (±0.44%) |
1.00 |
E2E_Evaluator_draft_04 |
101 ops/sec (±0.69%) |
121 ops/sec (±0.48%) |
1.20 |
E2E_Evaluator_fabric_mod |
592 ops/sec (±0.13%) |
603 ops/sec (±0.10%) |
1.02 |
E2E_Evaluator_geojson |
37.09 ops/sec (±0.23%) |
38.4 ops/sec (±0.17%) |
1.04 |
E2E_Evaluator_gitpod_configuration |
1052 ops/sec (±0.16%) |
1054 ops/sec (±0.43%) |
1.00 |
E2E_Evaluator_helm_chart_lock |
358 ops/sec (±0.29%) |
358 ops/sec (±0.14%) |
1 |
E2E_Evaluator_importmap |
1552 ops/sec (±0.11%) |
1532 ops/sec (±0.10%) |
0.99 |
E2E_Evaluator_jasmine |
1273 ops/sec (±0.13%) |
1270 ops/sec (±0.29%) |
1.00 |
E2E_Evaluator_jsconfig |
863 ops/sec (±0.18%) |
871 ops/sec (±0.19%) |
1.01 |
E2E_Evaluator_jshintrc |
592 ops/sec (±0.21%) |
595 ops/sec (±0.09%) |
1.01 |
E2E_Evaluator_krakend |
3449 ops/sec (±0.16%) |
3463 ops/sec (±0.17%) |
1.00 |
E2E_Evaluator_lazygit |
2672 ops/sec (±0.14%) |
2696 ops/sec (±0.15%) |
1.01 |
E2E_Evaluator_lerna |
1271 ops/sec (±0.15%) |
1268 ops/sec (±0.13%) |
1.00 |
E2E_Evaluator_nest_cli |
1119 ops/sec (±0.12%) |
1109 ops/sec (±0.10%) |
0.99 |
E2E_Evaluator_omc |
21761 ops/sec (±0.09%) |
21922 ops/sec (±0.22%) |
1.01 |
E2E_Evaluator_omnisharp |
810 ops/sec (±0.12%) |
809 ops/sec (±0.12%) |
1.00 |
E2E_Evaluator_openapi |
68.12 ops/sec (±1.30%) |
79.88 ops/sec (±0.65%) |
1.17 |
E2E_Evaluator_pre_commit_hooks |
799 ops/sec (±0.97%) |
796 ops/sec (±0.10%) |
1.00 |
E2E_Evaluator_pulumi |
296 ops/sec (±0.14%) |
295 ops/sec (±0.52%) |
1.00 |
E2E_Evaluator_semantic_release |
1550 ops/sec (±0.41%) |
1533 ops/sec (±0.43%) |
0.99 |
E2E_Evaluator_stale |
1269 ops/sec (±0.16%) |
1259 ops/sec (±0.10%) |
0.99 |
E2E_Evaluator_stylecop |
970 ops/sec (±0.28%) |
977 ops/sec (±0.13%) |
1.01 |
E2E_Evaluator_tmuxinator |
2666 ops/sec (±0.13%) |
2671 ops/sec (±0.48%) |
1.00 |
E2E_Evaluator_ui5 |
719 ops/sec (±0.19%) |
721 ops/sec (±0.46%) |
1.00 |
E2E_Evaluator_ui5_manifest |
248 ops/sec (±0.72%) |
255 ops/sec (±0.16%) |
1.03 |
E2E_Evaluator_unreal_engine_uproject |
806 ops/sec (±0.16%) |
815 ops/sec (±0.13%) |
1.01 |
E2E_Evaluator_vercel |
1230 ops/sec (±0.11%) |
1234 ops/sec (±0.15%) |
1.00 |
E2E_Evaluator_yamllint |
1702 ops/sec (±0.93%) |
1685 ops/sec (±0.10%) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 0db1303 | Previous: 9334210 | Ratio |
|---|---|---|---|
E2E_Compiler_adaptivecard |
922746856.9999928 ns/iter |
937015233.000011 ns/iter |
0.98 |
E2E_Compiler_ansible_meta |
28540611.879998323 ns/iter |
28181421.599999797 ns/iter |
1.01 |
E2E_Compiler_aws_cdk |
512699.98496239964 ns/iter |
506525.44179319905 ns/iter |
1.01 |
E2E_Compiler_babelrc |
3496251.5792079726 ns/iter |
3402519.208737859 ns/iter |
1.03 |
E2E_Compiler_clang_format |
19464848.657895874 ns/iter |
18204188.894737914 ns/iter |
1.07 |
E2E_Compiler_cmake_presets |
190954605.99999115 ns/iter |
188476906.50000003 ns/iter |
1.01 |
E2E_Compiler_code_climate |
2873425.085714161 ns/iter |
2824882.004048558 ns/iter |
1.02 |
E2E_Compiler_cql2 |
160169172.74998832 ns/iter |
155930312.80000106 ns/iter |
1.03 |
E2E_Compiler_cspell |
49356017.78571399 ns/iter |
49376124.9285691 ns/iter |
1.00 |
E2E_Compiler_cypress |
5899158.88235307 ns/iter |
5856574.672268552 ns/iter |
1.01 |
E2E_Compiler_deno |
8412894.036144922 ns/iter |
8365974.261905541 ns/iter |
1.01 |
E2E_Compiler_dependabot |
4279123.672839337 ns/iter |
4239632.120481792 ns/iter |
1.01 |
E2E_Compiler_draft_04 |
16453668.465116216 ns/iter |
16272725.651164321 ns/iter |
1.01 |
E2E_Compiler_fabric_mod |
5871868.349999923 ns/iter |
5848746.661156327 ns/iter |
1.00 |
E2E_Compiler_geojson |
25502553.629630037 ns/iter |
25515592.571427498 ns/iter |
1.00 |
E2E_Compiler_gitpod_configuration |
6002757.273504202 ns/iter |
5951706.017094305 ns/iter |
1.01 |
E2E_Compiler_helm_chart_lock |
845567.8321256265 ns/iter |
843477.9723224492 ns/iter |
1.00 |
E2E_Compiler_importmap |
416968.92444973206 ns/iter |
414032.6644931524 ns/iter |
1.01 |
E2E_Compiler_jasmine |
1689414.516908241 ns/iter |
1663935.5534439639 ns/iter |
1.02 |
E2E_Compiler_jshintrc |
4855167.326388552 ns/iter |
4806263.87586183 ns/iter |
1.01 |
E2E_Compiler_jsconfig |
22199912.612903047 ns/iter |
22395602.374999158 ns/iter |
0.99 |
E2E_Compiler_krakend |
233014538.66667998 ns/iter |
239267757.99998268 ns/iter |
0.97 |
E2E_Compiler_lazygit |
37246448.368421175 ns/iter |
36623837.84210545 ns/iter |
1.02 |
E2E_Compiler_lerna |
1856727.2625995157 ns/iter |
1825245.774025993 ns/iter |
1.02 |
E2E_Compiler_nest_cli |
9908094.295774806 ns/iter |
9721912.569443386 ns/iter |
1.02 |
E2E_Compiler_omc |
1441016187.999992 ns/iter |
1412044175.0000055 ns/iter |
1.02 |
E2E_Compiler_omnisharp |
7411005.617021321 ns/iter |
7355915.343750278 ns/iter |
1.01 |
E2E_Compiler_openapi |
1101629570 ns/iter |
1093366341.0000918 ns/iter |
1.01 |
E2E_Compiler_pre_commit_hooks |
5527309.849206011 ns/iter |
5474440.062499752 ns/iter |
1.01 |
E2E_Compiler_pulumi |
4706793.554053906 ns/iter |
4614363.164473675 ns/iter |
1.02 |
E2E_Compiler_semantic_release |
1784375.511450341 ns/iter |
1772089.4559192343 ns/iter |
1.01 |
E2E_Compiler_stale |
2160928.81790128 ns/iter |
2136325.577981936 ns/iter |
1.01 |
E2E_Compiler_stylecop |
6807134.177569888 ns/iter |
6457488.112149693 ns/iter |
1.05 |
E2E_Compiler_tmuxinator |
2208894.1735015404 ns/iter |
2186700.4906251705 ns/iter |
1.01 |
E2E_Compiler_ui5 |
136605169.79999784 ns/iter |
135491593.59999976 ns/iter |
1.01 |
E2E_Compiler_ui5_manifest |
1971380753.0000055 ns/iter |
1881393763.0000055 ns/iter |
1.05 |
E2E_Compiler_unreal_engine_uproject |
4963143.900000335 ns/iter |
4869891.381944392 ns/iter |
1.02 |
E2E_Compiler_vercel |
14431224.877550531 ns/iter |
14151806.306124259 ns/iter |
1.02 |
E2E_Compiler_yamllint |
451555.8992898796 ns/iter |
447899.6316793772 ns/iter |
1.01 |
E2E_Evaluator_adaptivecard |
56772.70880979195 ns/iter |
55094.29822911676 ns/iter |
1.03 |
E2E_Evaluator_ansible_meta |
320582.65039153537 ns/iter |
316523.7150635399 ns/iter |
1.01 |
E2E_Evaluator_aws_cdk |
71561.37076378308 ns/iter |
70843.69866910634 ns/iter |
1.01 |
E2E_Evaluator_babelrc |
159682.97608938557 ns/iter |
158185.75022687452 ns/iter |
1.01 |
E2E_Evaluator_clang_format |
139554.2636238378 ns/iter |
137351.92777012134 ns/iter |
1.02 |
E2E_Evaluator_cmake_presets |
5869717.859504141 ns/iter |
6236969.009901574 ns/iter |
0.94 |
E2E_Evaluator_code_climate |
284056.21106141177 ns/iter |
279513.7297297517 ns/iter |
1.02 |
E2E_Evaluator_cql2 |
266137.29369299556 ns/iter |
272140.2755692596 ns/iter |
0.98 |
E2E_Evaluator_cspell |
730653.8526645568 ns/iter |
696632.8375124537 ns/iter |
1.05 |
E2E_Evaluator_cypress |
231197.42077752878 ns/iter |
233142.90484081683 ns/iter |
0.99 |
E2E_Evaluator_deno |
402657.1775043977 ns/iter |
396071.59786275396 ns/iter |
1.02 |
E2E_Evaluator_dependabot |
563904.4681708607 ns/iter |
559807.9072165196 ns/iter |
1.01 |
E2E_Evaluator_draft_04 |
9930407.984848505 ns/iter |
10218626.142856074 ns/iter |
0.97 |
E2E_Evaluator_fabric_mod |
981275.1161825305 ns/iter |
979311.9971987663 ns/iter |
1.00 |
E2E_Evaluator_geojson |
30693974.478261363 ns/iter |
31258390.31818342 ns/iter |
0.98 |
E2E_Evaluator_gitpod_configuration |
325839.11157796043 ns/iter |
317579.4245027283 ns/iter |
1.03 |
E2E_Evaluator_helm_chart_lock |
471202.53035357787 ns/iter |
459959.7758846481 ns/iter |
1.02 |
E2E_Evaluator_importmap |
72747.212124393 ns/iter |
74995.70290624075 ns/iter |
0.97 |
E2E_Evaluator_jasmine |
164157.61716172678 ns/iter |
168537.16843117622 ns/iter |
0.97 |
E2E_Evaluator_jshintrc |
1325407.0396226754 ns/iter |
1320409.202626584 ns/iter |
1.00 |
E2E_Evaluator_jsconfig |
521669.4354243208 ns/iter |
524568.4981329177 ns/iter |
0.99 |
E2E_Evaluator_krakend |
268389.0255417896 ns/iter |
260943.21963144338 ns/iter |
1.03 |
E2E_Evaluator_lazygit |
192798.02970572494 ns/iter |
187706.49281150766 ns/iter |
1.03 |
E2E_Evaluator_lerna |
207320.20141341674 ns/iter |
204864.89498385182 ns/iter |
1.01 |
E2E_Evaluator_nest_cli |
262426.5438859799 ns/iter |
256153.3797744749 ns/iter |
1.02 |
E2E_Evaluator_omc |
31063.02301756161 ns/iter |
30935.81938525386 ns/iter |
1.00 |
E2E_Evaluator_omnisharp |
719553.1173469557 ns/iter |
738765.6129706235 ns/iter |
0.97 |
E2E_Evaluator_openapi |
16194479.452381182 ns/iter |
16490675.809523378 ns/iter |
0.98 |
E2E_Evaluator_pre_commit_hooks |
619251.2873563172 ns/iter |
592134.4438818295 ns/iter |
1.05 |
E2E_Evaluator_pulumi |
867667.6926890111 ns/iter |
886655.8513852593 ns/iter |
0.98 |
E2E_Evaluator_semantic_release |
138398.4607072752 ns/iter |
141352.865249655 ns/iter |
0.98 |
E2E_Evaluator_stale |
205577.759046788 ns/iter |
211928.5987280241 ns/iter |
0.97 |
E2E_Evaluator_stylecop |
379687.65426103614 ns/iter |
375973.90032676945 ns/iter |
1.01 |
E2E_Evaluator_tmuxinator |
139957.16810344846 ns/iter |
134275.1738049809 ns/iter |
1.04 |
E2E_Evaluator_ui5 |
728671.525987567 ns/iter |
719091.8212461371 ns/iter |
1.01 |
E2E_Evaluator_ui5_manifest |
3492439.245000014 ns/iter |
3618067.7989418823 ns/iter |
0.97 |
E2E_Evaluator_unreal_engine_uproject |
550942.207221359 ns/iter |
544049.3227308275 ns/iter |
1.01 |
E2E_Evaluator_vercel |
394159.7852726269 ns/iter |
391339.34775373613 ns/iter |
1.01 |
E2E_Evaluator_yamllint |
17261.363289746987 ns/iter |
17436.648212865468 ns/iter |
0.99 |
Micro_Draft4_Meta_1_No_Callback |
283.5853714495057 ns/iter |
286.4701724329473 ns/iter |
0.99 |
Micro_Draft4_Required_Properties |
690.5630062704691 ns/iter |
716.5050870964983 ns/iter |
0.96 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
33.7253706014071 ns/iter |
36.65562203799636 ns/iter |
0.92 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
15.985434533325154 ns/iter |
16.203143722286445 ns/iter |
0.99 |
Micro_Draft4_Items_Schema |
674.2730779555071 ns/iter |
629.2294163505386 ns/iter |
1.07 |
Micro_Draft4_Nested_Object |
6.847581003282798 ns/iter |
6.861908879408726 ns/iter |
1.00 |
Micro_Draft4_Properties_Triad_Optional |
384.4541245864818 ns/iter |
394.08815578864716 ns/iter |
0.98 |
Micro_Draft4_Properties_Triad_Closed |
320.56837031221875 ns/iter |
327.97544507238985 ns/iter |
0.98 |
Micro_Draft4_Properties_Triad_Required |
381.11630984962943 ns/iter |
407.3053059338622 ns/iter |
0.94 |
Micro_Draft4_Properties_Closed |
88.97035885465185 ns/iter |
86.76443961646191 ns/iter |
1.03 |
Micro_Draft4_Non_Recursive_Ref |
35.54189896606503 ns/iter |
39.02761754166956 ns/iter |
0.91 |
Micro_Draft4_Pattern_Properties_True |
268.76320478696596 ns/iter |
261.7076203558729 ns/iter |
1.03 |
Micro_Draft4_Ref_To_Single_Property |
15.88128552090395 ns/iter |
16.18842645521872 ns/iter |
0.98 |
Micro_Draft4_Additional_Properties_Type |
63.10056970187755 ns/iter |
71.95946218420137 ns/iter |
0.88 |
Micro_Draft4_Nested_Oneof |
89.47120719797864 ns/iter |
91.53444470785 ns/iter |
0.98 |
Micro_Draft4_Short_Enum |
17.422950206028393 ns/iter |
18.407567526781616 ns/iter |
0.95 |
Micro_Draft4_Long_Enum |
22.787306938193446 ns/iter |
23.28004148689329 ns/iter |
0.98 |
Micro_Draft4_Long_Enum_Short_Strings |
17.734443510184036 ns/iter |
18.374392919878588 ns/iter |
0.97 |
Micro_Draft4_Type_Object |
12.450468091382158 ns/iter |
13.0774095073152 ns/iter |
0.95 |
Micro_Draft4_Ref_Single_100 |
3035691.4155839607 ns/iter |
3033849.255411085 ns/iter |
1.00 |
Micro_Draft4_Ref_Many_Nested |
4392841781.000015 ns/iter |
5398339935.999957 ns/iter |
0.81 |
Micro_Draft6_Property_Names |
145.42200018472772 ns/iter |
137.6944717537788 ns/iter |
1.06 |
Micro_Draft7_If_Then_Else |
42.9900245224737 ns/iter |
43.643298011068374 ns/iter |
0.99 |
Micro_2019_09_Unevaluated_Properties |
61.16885140256477 ns/iter |
55.08170035143979 ns/iter |
1.11 |
Micro_2020_12_Dynamic_Ref |
535.4629635588734 ns/iter |
538.51584004518 ns/iter |
0.99 |
Micro_2020_12_Dynamic_Ref_Single |
12.821147007319023 ns/iter |
13.074970287610167 ns/iter |
0.98 |
Micro_2020_12_Simple_Output_Mask |
138883.7143993546 ns/iter |
139580.4126475964 ns/iter |
1.00 |
Micro_2020_12_Simple_Output_Annotations |
167854.3970944083 ns/iter |
170090.5593014776 ns/iter |
0.99 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
53403794.61537956 ns/iter |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 0db1303 | Previous: 9334210 | Ratio |
|---|---|---|---|
E2E_Compiler_adaptivecard |
634789915.9999883 ns/iter |
743284499.9999589 ns/iter |
0.85 |
E2E_Compiler_ansible_meta |
26204594.538462255 ns/iter |
31051925.73913052 ns/iter |
0.84 |
E2E_Compiler_aws_cdk |
377314.5777777785 ns/iter |
413302.33703701483 ns/iter |
0.91 |
E2E_Compiler_babelrc |
2880321.016194467 ns/iter |
3372402.8897959404 ns/iter |
0.85 |
E2E_Compiler_clang_format |
15880751.80434786 ns/iter |
16079456.60416732 ns/iter |
0.99 |
E2E_Compiler_cmake_presets |
167913531.25000796 ns/iter |
179791499.99998754 ns/iter |
0.93 |
E2E_Compiler_code_climate |
2664827.735074694 ns/iter |
3149289.080291663 ns/iter |
0.85 |
E2E_Compiler_cql2 |
120931618.16666983 ns/iter |
132901175.00000635 ns/iter |
0.91 |
E2E_Compiler_cspell |
37979078.947366334 ns/iter |
45959443.5882309 ns/iter |
0.83 |
E2E_Compiler_cypress |
5362211.440298317 ns/iter |
6822661.6074765865 ns/iter |
0.79 |
E2E_Compiler_deno |
7511455.4455448305 ns/iter |
9909767.032259116 ns/iter |
0.76 |
E2E_Compiler_dependabot |
4271158.885542085 ns/iter |
4955281.420635286 ns/iter |
0.86 |
E2E_Compiler_draft_04 |
12965784.716666916 ns/iter |
14351853.227271827 ns/iter |
0.90 |
E2E_Compiler_fabric_mod |
4658628.378378451 ns/iter |
5817261.861538835 ns/iter |
0.80 |
E2E_Compiler_geojson |
26409874.99999828 ns/iter |
31474909.722223606 ns/iter |
0.84 |
E2E_Compiler_gitpod_configuration |
5232957.499999884 ns/iter |
6177184.770492062 ns/iter |
0.85 |
E2E_Compiler_helm_chart_lock |
584735.5340531438 ns/iter |
679126.1211305832 ns/iter |
0.86 |
E2E_Compiler_importmap |
268212.2086856163 ns/iter |
348150.6663135533 ns/iter |
0.77 |
E2E_Compiler_jasmine |
1271788.4025501206 ns/iter |
1443250.6108785723 ns/iter |
0.88 |
E2E_Compiler_jshintrc |
3589403.5320196394 ns/iter |
3653192.523077054 ns/iter |
0.98 |
E2E_Compiler_jsconfig |
21194975.694443643 ns/iter |
20213058.823531706 ns/iter |
1.05 |
E2E_Compiler_krakend |
202445458.33332947 ns/iter |
203765194.33333823 ns/iter |
0.99 |
E2E_Compiler_lazygit |
37289004.36842172 ns/iter |
39140487.15384629 ns/iter |
0.95 |
E2E_Compiler_lerna |
1760243.451025047 ns/iter |
1645400.3271460384 ns/iter |
1.07 |
E2E_Compiler_nest_cli |
9776976.562500294 ns/iter |
8695139.21176456 ns/iter |
1.12 |
E2E_Compiler_omc |
1474155084.0000172 ns/iter |
1503367584.0001023 ns/iter |
0.98 |
E2E_Compiler_omnisharp |
7621845.720720316 ns/iter |
7556240.9306922015 ns/iter |
1.01 |
E2E_Compiler_openapi |
1024791124.9999788 ns/iter |
970738833.0000412 ns/iter |
1.06 |
E2E_Compiler_pre_commit_hooks |
4327682.131736583 ns/iter |
5069357.968553066 ns/iter |
0.85 |
E2E_Compiler_pulumi |
3730435.8288769373 ns/iter |
4468632.075471296 ns/iter |
0.83 |
E2E_Compiler_semantic_release |
1388033.1920904096 ns/iter |
1629591.5596530486 ns/iter |
0.85 |
E2E_Compiler_stale |
1634003.5814479655 ns/iter |
2199781.4960630974 ns/iter |
0.74 |
E2E_Compiler_stylecop |
5853586.0161290355 ns/iter |
8397873.091954436 ns/iter |
0.70 |
E2E_Compiler_tmuxinator |
1741150.366748168 ns/iter |
1918260.0120118922 ns/iter |
0.91 |
E2E_Compiler_ui5 |
127685444.33333772 ns/iter |
164755224.999999 ns/iter |
0.78 |
E2E_Compiler_ui5_manifest |
1536325459.000011 ns/iter |
2039680707.9999917 ns/iter |
0.75 |
E2E_Compiler_unreal_engine_uproject |
4039024.441340824 ns/iter |
4299544.520547785 ns/iter |
0.94 |
E2E_Compiler_vercel |
14837950.520832995 ns/iter |
16332690.595744042 ns/iter |
0.91 |
E2E_Compiler_yamllint |
311954.7413793096 ns/iter |
367492.8613445165 ns/iter |
0.85 |
E2E_Evaluator_adaptivecard |
45385.675593930384 ns/iter |
46311.35648092908 ns/iter |
0.98 |
E2E_Evaluator_ansible_meta |
214226.81926009562 ns/iter |
205420.44071147157 ns/iter |
1.04 |
E2E_Evaluator_aws_cdk |
43898.26885565503 ns/iter |
48991.395782272244 ns/iter |
0.90 |
E2E_Evaluator_babelrc |
102347.23421471256 ns/iter |
124145.1348088693 ns/iter |
0.82 |
E2E_Evaluator_clang_format |
100804.66776551149 ns/iter |
131610.7813415624 ns/iter |
0.77 |
E2E_Evaluator_cmake_presets |
3872726.3888887367 ns/iter |
6077105.595419608 ns/iter |
0.64 |
E2E_Evaluator_code_climate |
168785.8229710534 ns/iter |
336085.7636801364 ns/iter |
0.50 |
E2E_Evaluator_cql2 |
176941.80225281755 ns/iter |
300499.7506648886 ns/iter |
0.59 |
E2E_Evaluator_cspell |
449674.0734924685 ns/iter |
1041287.1300577527 ns/iter |
0.43 |
E2E_Evaluator_cypress |
153698.52161932425 ns/iter |
330151.3897581617 ns/iter |
0.47 |
E2E_Evaluator_deno |
256487.03489638722 ns/iter |
395854.5062657133 ns/iter |
0.65 |
E2E_Evaluator_dependabot |
370600.3059006219 ns/iter |
490134.3805836889 ns/iter |
0.76 |
E2E_Evaluator_draft_04 |
6369087.220339341 ns/iter |
7880037.836734888 ns/iter |
0.81 |
E2E_Evaluator_fabric_mod |
622328.9636663707 ns/iter |
1308368.8445423937 ns/iter |
0.48 |
E2E_Evaluator_geojson |
16609668.666667348 ns/iter |
32255591.666667745 ns/iter |
0.51 |
E2E_Evaluator_gitpod_configuration |
216150.15985542972 ns/iter |
318772.0297029892 ns/iter |
0.68 |
E2E_Evaluator_helm_chart_lock |
267064.8996948871 ns/iter |
501075.38476562576 ns/iter |
0.53 |
E2E_Evaluator_importmap |
43398.74909180554 ns/iter |
74003.6386106218 ns/iter |
0.59 |
E2E_Evaluator_jasmine |
105896.8580769875 ns/iter |
210015.3005661356 ns/iter |
0.50 |
E2E_Evaluator_jshintrc |
974816.655737701 ns/iter |
1599054.995525727 ns/iter |
0.61 |
E2E_Evaluator_jsconfig |
357390.2943568964 ns/iter |
574364.1660000094 ns/iter |
0.62 |
E2E_Evaluator_krakend |
158615.32188463275 ns/iter |
212308.92627734836 ns/iter |
0.75 |
E2E_Evaluator_lazygit |
107975.85973749007 ns/iter |
185416.80768301955 ns/iter |
0.58 |
E2E_Evaluator_lerna |
129409.2910120563 ns/iter |
239448.8741838048 ns/iter |
0.54 |
E2E_Evaluator_nest_cli |
153774.3107135071 ns/iter |
256892.05694071078 ns/iter |
0.60 |
E2E_Evaluator_omc |
20145.051611605606 ns/iter |
23166.346570776506 ns/iter |
0.87 |
E2E_Evaluator_omnisharp |
457579.7053628027 ns/iter |
663816.005663397 ns/iter |
0.69 |
E2E_Evaluator_openapi |
8633532.416666867 ns/iter |
14486465.517240409 ns/iter |
0.60 |
E2E_Evaluator_pre_commit_hooks |
379594.87860644545 ns/iter |
473149.7558217046 ns/iter |
0.80 |
E2E_Evaluator_pulumi |
561744.9124498127 ns/iter |
764139.2438765147 ns/iter |
0.74 |
E2E_Evaluator_semantic_release |
90167.66580711503 ns/iter |
128432.75805310046 ns/iter |
0.70 |
E2E_Evaluator_stale |
124917.55962668819 ns/iter |
160444.2367553254 ns/iter |
0.78 |
E2E_Evaluator_stylecop |
232359.60610933468 ns/iter |
288449.6437389664 ns/iter |
0.81 |
E2E_Evaluator_tmuxinator |
85819.11887456181 ns/iter |
121369.71479409652 ns/iter |
0.71 |
E2E_Evaluator_ui5 |
434696.676687129 ns/iter |
703103.5665188367 ns/iter |
0.62 |
E2E_Evaluator_ui5_manifest |
2067715.4879517085 ns/iter |
2675587.8576778653 ns/iter |
0.77 |
E2E_Evaluator_unreal_engine_uproject |
370865.5621085413 ns/iter |
464015.1926207371 ns/iter |
0.80 |
E2E_Evaluator_vercel |
259933.43997149452 ns/iter |
295853.6948023192 ns/iter |
0.88 |
E2E_Evaluator_yamllint |
12438.857647541685 ns/iter |
15852.779336712025 ns/iter |
0.78 |
Micro_Draft4_Meta_1_No_Callback |
201.51025852051697 ns/iter |
236.84813818247758 ns/iter |
0.85 |
Micro_Draft4_Required_Properties |
478.98648315549985 ns/iter |
480.79048750949414 ns/iter |
1.00 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
20.612981870501464 ns/iter |
21.83682442255995 ns/iter |
0.94 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
7.3701955516783295 ns/iter |
8.219924927707995 ns/iter |
0.90 |
Micro_Draft4_Items_Schema |
474.9235925621221 ns/iter |
713.2856669999228 ns/iter |
0.67 |
Micro_Draft4_Nested_Object |
2.943499535030733 ns/iter |
4.0045594481350575 ns/iter |
0.74 |
Micro_Draft4_Properties_Triad_Optional |
280.05967048940425 ns/iter |
323.9199455175272 ns/iter |
0.86 |
Micro_Draft4_Properties_Triad_Closed |
222.11616322497235 ns/iter |
279.19985671547136 ns/iter |
0.80 |
Micro_Draft4_Properties_Triad_Required |
275.54991198930065 ns/iter |
320.9084122136159 ns/iter |
0.86 |
Micro_Draft4_Properties_Closed |
50.31033973374683 ns/iter |
52.18229485818776 ns/iter |
0.96 |
Micro_Draft4_Non_Recursive_Ref |
24.0731296853099 ns/iter |
23.96322626250217 ns/iter |
1.00 |
Micro_Draft4_Pattern_Properties_True |
163.16236973283816 ns/iter |
162.58854948744298 ns/iter |
1.00 |
Micro_Draft4_Ref_To_Single_Property |
7.729470910802385 ns/iter |
9.949443368179628 ns/iter |
0.78 |
Micro_Draft4_Additional_Properties_Type |
42.418994541339636 ns/iter |
58.975707426244625 ns/iter |
0.72 |
Micro_Draft4_Nested_Oneof |
56.237430467230524 ns/iter |
79.3938181161007 ns/iter |
0.71 |
Micro_Draft4_Short_Enum |
8.959202781316973 ns/iter |
12.019658196018316 ns/iter |
0.75 |
Micro_Draft4_Long_Enum |
23.97204812231567 ns/iter |
33.95459194415934 ns/iter |
0.71 |
Micro_Draft4_Long_Enum_Short_Strings |
10.363900585327366 ns/iter |
14.912619550935052 ns/iter |
0.69 |
Micro_Draft4_Type_Object |
5.932202866156693 ns/iter |
7.8762891967062405 ns/iter |
0.75 |
Micro_Draft4_Ref_Single_100 |
2191682.128930726 ns/iter |
3061826.360514672 ns/iter |
0.72 |
Micro_Draft4_Ref_Many_Nested |
2967515290.999984 ns/iter |
4546847874.999912 ns/iter |
0.65 |
Micro_Draft6_Property_Names |
104.58258542824677 ns/iter |
154.1668200464554 ns/iter |
0.68 |
Micro_Draft7_If_Then_Else |
30.055087773556327 ns/iter |
45.323155736458745 ns/iter |
0.66 |
Micro_2019_09_Unevaluated_Properties |
37.72880762519639 ns/iter |
70.88602459714835 ns/iter |
0.53 |
Micro_2020_12_Dynamic_Ref |
429.5714517134527 ns/iter |
776.0795793631878 ns/iter |
0.55 |
Micro_2020_12_Dynamic_Ref_Single |
5.88417470686445 ns/iter |
10.616335564002863 ns/iter |
0.55 |
Micro_2020_12_Simple_Output_Mask |
136264.59298780226 ns/iter |
218261.5502465015 ns/iter |
0.62 |
Micro_2020_12_Simple_Output_Annotations |
154939.37687688123 ns/iter |
271688.9173259795 ns/iter |
0.57 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
42413742.18750593 ns/iter |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 0db1303 | Previous: 9334210 | Ratio |
|---|---|---|---|
Micro_2020_12_Dynamic_Ref |
621.1243635913048 ns/iter |
609.8632902405589 ns/iter |
1.02 |
Micro_2020_12_Dynamic_Ref_Single |
11.013052739644385 ns/iter |
12.272006624429183 ns/iter |
0.90 |
Micro_2020_12_Simple_Output_Mask |
141987.62926535835 ns/iter |
138267.48954057178 ns/iter |
1.03 |
Micro_2020_12_Simple_Output_Annotations |
174670.15451822264 ns/iter |
175776.00720164273 ns/iter |
0.99 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
62760302.54545359 ns/iter |
||
Micro_2019_09_Unevaluated_Properties |
48.07299380888416 ns/iter |
47.68523129490416 ns/iter |
1.01 |
Micro_Draft7_If_Then_Else |
46.70239984095535 ns/iter |
46.6662466558918 ns/iter |
1.00 |
Micro_Draft6_Property_Names |
164.12508685345085 ns/iter |
159.48139807035005 ns/iter |
1.03 |
Micro_Draft4_Meta_1_No_Callback |
256.640436588163 ns/iter |
264.01612473426036 ns/iter |
0.97 |
Micro_Draft4_Required_Properties |
561.144758118273 ns/iter |
555.559355186165 ns/iter |
1.01 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
31.020251298105837 ns/iter |
31.38051170315298 ns/iter |
0.99 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
13.25434245799855 ns/iter |
14.089987306490947 ns/iter |
0.94 |
Micro_Draft4_Items_Schema |
528.9815544616304 ns/iter |
533.0151685908247 ns/iter |
0.99 |
Micro_Draft4_Nested_Object |
5.723126618219069 ns/iter |
6.967304777681717 ns/iter |
0.82 |
Micro_Draft4_Properties_Triad_Optional |
469.204446974029 ns/iter |
496.1137428325589 ns/iter |
0.95 |
Micro_Draft4_Properties_Triad_Closed |
388.36271205076895 ns/iter |
415.4807851162378 ns/iter |
0.93 |
Micro_Draft4_Properties_Triad_Required |
485.0834619911579 ns/iter |
498.7875583782691 ns/iter |
0.97 |
Micro_Draft4_Properties_Closed |
80.08695504589183 ns/iter |
78.86641805962849 ns/iter |
1.02 |
Micro_Draft4_Non_Recursive_Ref |
15.997332284989241 ns/iter |
16.179492315779143 ns/iter |
0.99 |
Micro_Draft4_Pattern_Properties_True |
244.03163186730205 ns/iter |
255.06899709179098 ns/iter |
0.96 |
Micro_Draft4_Ref_To_Single_Property |
13.282764515955611 ns/iter |
14.13203093940124 ns/iter |
0.94 |
Micro_Draft4_Additional_Properties_Type |
20.942030444485976 ns/iter |
21.54702149517988 ns/iter |
0.97 |
Micro_Draft4_Nested_Oneof |
112.7243448085484 ns/iter |
111.83449326092904 ns/iter |
1.01 |
Micro_Draft4_Short_Enum |
18.707641935229045 ns/iter |
18.716650500470866 ns/iter |
1.00 |
Micro_Draft4_Long_Enum |
21.25377828463999 ns/iter |
22.284774502786327 ns/iter |
0.95 |
Micro_Draft4_Long_Enum_Short_Strings |
18.72006007833734 ns/iter |
18.754429557973015 ns/iter |
1.00 |
Micro_Draft4_Type_Object |
11.011694167630328 ns/iter |
12.253162598067211 ns/iter |
0.90 |
Micro_Draft4_Ref_Single_100 |
3089928.632743172 ns/iter |
3112452.1511113322 ns/iter |
0.99 |
Micro_Draft4_Ref_Many_Nested |
5508917463.999978 ns/iter |
5022018363.999905 ns/iter |
1.10 |
E2E_Compiler_adaptivecard |
974501779.9999686 ns/iter |
967350796.0000051 ns/iter |
1.01 |
E2E_Compiler_ansible_meta |
31493943.409088846 ns/iter |
31986780.95454129 ns/iter |
0.98 |
E2E_Compiler_aws_cdk |
560405.8569144753 ns/iter |
565623.927560314 ns/iter |
0.99 |
E2E_Compiler_babelrc |
3749017.6149734915 ns/iter |
3810418.86885276 ns/iter |
0.98 |
E2E_Compiler_clang_format |
20484994.29411897 ns/iter |
20570856.176468223 ns/iter |
1.00 |
E2E_Compiler_cmake_presets |
193853703.00000206 ns/iter |
194454951.25000888 ns/iter |
1.00 |
E2E_Compiler_code_climate |
3180855.9136364195 ns/iter |
3236307.5767444717 ns/iter |
0.98 |
E2E_Compiler_cql2 |
169540784.2500174 ns/iter |
169273759.00002062 ns/iter |
1.00 |
E2E_Compiler_cspell |
53027041.692311846 ns/iter |
52059417.071429186 ns/iter |
1.02 |
E2E_Compiler_cypress |
6116985.147825645 ns/iter |
6233997.876106272 ns/iter |
0.98 |
E2E_Compiler_deno |
9294778.407893857 ns/iter |
9412838.66216269 ns/iter |
0.99 |
E2E_Compiler_dependabot |
4776765.761904881 ns/iter |
4827589.779310513 ns/iter |
0.99 |
E2E_Compiler_draft_04 |
17625534.824998114 ns/iter |
18240933.692310043 ns/iter |
0.97 |
E2E_Compiler_fabric_mod |
6513811.906542305 ns/iter |
6566035.485981625 ns/iter |
0.99 |
E2E_Compiler_geojson |
28524951.079998575 ns/iter |
28168018.440001108 ns/iter |
1.01 |
E2E_Compiler_gitpod_configuration |
6629180.056603339 ns/iter |
6726570.028570763 ns/iter |
0.99 |
E2E_Compiler_helm_chart_lock |
922726.5085864796 ns/iter |
933822.9475806889 ns/iter |
0.99 |
E2E_Compiler_importmap |
452902.0576051903 ns/iter |
456646.6359477214 ns/iter |
0.99 |
E2E_Compiler_jasmine |
1836550.0892388995 ns/iter |
1866395.2520106207 ns/iter |
0.98 |
E2E_Compiler_jshintrc |
5328325.295454478 ns/iter |
5357624.923664032 ns/iter |
0.99 |
E2E_Compiler_jsconfig |
24071738.55172475 ns/iter |
24178462.413793758 ns/iter |
1.00 |
E2E_Compiler_krakend |
243815403.00002298 ns/iter |
240318210.66667664 ns/iter |
1.01 |
E2E_Compiler_lazygit |
40661519.35293928 ns/iter |
40426780.70588328 ns/iter |
1.01 |
E2E_Compiler_lerna |
2045498.1231673588 ns/iter |
2141346.8888889086 ns/iter |
0.96 |
E2E_Compiler_nest_cli |
10652721.954544852 ns/iter |
10888989.234375756 ns/iter |
0.98 |
E2E_Compiler_omc |
1557862794.000016 ns/iter |
1546767956.9999292 ns/iter |
1.01 |
E2E_Compiler_omnisharp |
8134891.744186175 ns/iter |
8222835.6470589945 ns/iter |
0.99 |
E2E_Compiler_openapi |
1190484031.999972 ns/iter |
1193625323.9999814 ns/iter |
1.00 |
E2E_Compiler_pre_commit_hooks |
6102261.417390765 ns/iter |
6183927.4910714235 ns/iter |
0.99 |
E2E_Compiler_pulumi |
5183115.266667032 ns/iter |
5215444.148148486 ns/iter |
0.99 |
E2E_Compiler_semantic_release |
1988684.9005682191 ns/iter |
2022903.253602389 ns/iter |
0.98 |
E2E_Compiler_stale |
2313765.2112210216 ns/iter |
2351295.2986578164 ns/iter |
0.98 |
E2E_Compiler_stylecop |
7097892.909091616 ns/iter |
7250988.793814649 ns/iter |
0.98 |
E2E_Compiler_tmuxinator |
2476022.837455619 ns/iter |
2479276.5851061502 ns/iter |
1.00 |
E2E_Compiler_ui5 |
143564202.19999108 ns/iter |
149157217.40001118 ns/iter |
0.96 |
E2E_Compiler_ui5_manifest |
2052877532.000025 ns/iter |
2064510228.0000174 ns/iter |
0.99 |
E2E_Compiler_unreal_engine_uproject |
5402558.209302098 ns/iter |
5471327.275590667 ns/iter |
0.99 |
E2E_Compiler_vercel |
15439755.266667515 ns/iter |
15555015.044444392 ns/iter |
0.99 |
E2E_Compiler_yamllint |
486902.28899717174 ns/iter |
528458.6190000483 ns/iter |
0.92 |
E2E_Evaluator_adaptivecard |
55347.064005122724 ns/iter |
57309.56186984534 ns/iter |
0.97 |
E2E_Evaluator_ansible_meta |
296915.8908315678 ns/iter |
302169.24074074975 ns/iter |
0.98 |
E2E_Evaluator_aws_cdk |
57676.3412606015 ns/iter |
57957.06557511477 ns/iter |
1.00 |
E2E_Evaluator_babelrc |
137176.70924502338 ns/iter |
139635.80226774415 ns/iter |
0.98 |
E2E_Evaluator_clang_format |
103718.27823240672 ns/iter |
113169.19622021021 ns/iter |
0.92 |
E2E_Evaluator_cmake_presets |
6100069.909091003 ns/iter |
5376313.7031248575 ns/iter |
1.13 |
E2E_Evaluator_code_climate |
227167.12853388416 ns/iter |
227624.9390879664 ns/iter |
1.00 |
E2E_Evaluator_cql2 |
265205.7300076034 ns/iter |
273045.13702846353 ns/iter |
0.97 |
E2E_Evaluator_cspell |
580654.1953642113 ns/iter |
602688.8125530523 ns/iter |
0.96 |
E2E_Evaluator_cypress |
171412.04221954316 ns/iter |
172423.65746953338 ns/iter |
0.99 |
E2E_Evaluator_deno |
347052.20886697253 ns/iter |
354760.66666667943 ns/iter |
0.98 |
E2E_Evaluator_dependabot |
482029.40594746073 ns/iter |
486811.72222218843 ns/iter |
0.99 |
E2E_Evaluator_draft_04 |
9816099.159420248 ns/iter |
8325346.250001076 ns/iter |
1.18 |
E2E_Evaluator_fabric_mod |
909960.0717948491 ns/iter |
962524.58791205 ns/iter |
0.95 |
E2E_Evaluator_geojson |
26276293.96154309 ns/iter |
26109135.07407565 ns/iter |
1.01 |
E2E_Evaluator_gitpod_configuration |
297912.61881193874 ns/iter |
291502.22861841857 ns/iter |
1.02 |
E2E_Evaluator_helm_chart_lock |
370959.71766550664 ns/iter |
369165.76597995195 ns/iter |
1.00 |
E2E_Evaluator_importmap |
61288.62251596754 ns/iter |
61558.89308732085 ns/iter |
1.00 |
E2E_Evaluator_jasmine |
143590.4879138704 ns/iter |
143992.8190965105 ns/iter |
1.00 |
E2E_Evaluator_jshintrc |
970508.8195592286 ns/iter |
1003785.2002861772 ns/iter |
0.97 |
E2E_Evaluator_jsconfig |
471666.81004074606 ns/iter |
462854.90172641835 ns/iter |
1.02 |
E2E_Evaluator_krakend |
225913.50065528858 ns/iter |
235686.93932359273 ns/iter |
0.96 |
E2E_Evaluator_lazygit |
164603.86074145252 ns/iter |
176813.30361625968 ns/iter |
0.93 |
E2E_Evaluator_lerna |
147064.52688862357 ns/iter |
165195.43638821907 ns/iter |
0.89 |
E2E_Evaluator_nest_cli |
228964.9603538864 ns/iter |
234523.4844844698 ns/iter |
0.98 |
E2E_Evaluator_omc |
29438.007396446534 ns/iter |
29549.95386115995 ns/iter |
1.00 |
E2E_Evaluator_omnisharp |
543246.6737254479 ns/iter |
562397.024390247 ns/iter |
0.97 |
E2E_Evaluator_openapi |
15804977.727270853 ns/iter |
13193933.333332544 ns/iter |
1.20 |
E2E_Evaluator_pre_commit_hooks |
549005.4710937997 ns/iter |
554259.3323029013 ns/iter |
0.99 |
E2E_Evaluator_pulumi |
831703.6919372347 ns/iter |
854552.0932515489 ns/iter |
0.97 |
E2E_Evaluator_semantic_release |
138636.96049771068 ns/iter |
138950.38972629682 ns/iter |
1.00 |
E2E_Evaluator_stale |
175248.3433390934 ns/iter |
178633.52236908113 ns/iter |
0.98 |
E2E_Evaluator_stylecop |
361205.6841004582 ns/iter |
350212.5022288421 ns/iter |
1.03 |
E2E_Evaluator_tmuxinator |
129273.00255754545 ns/iter |
137478.25757577652 ns/iter |
0.94 |
E2E_Evaluator_ui5 |
691479.2615230646 ns/iter |
684438.4867776863 ns/iter |
1.01 |
E2E_Evaluator_ui5_manifest |
3347787.219511857 ns/iter |
3330935.480952727 ns/iter |
1.01 |
E2E_Evaluator_unreal_engine_uproject |
515716.4610342147 ns/iter |
529069.0840978507 ns/iter |
0.97 |
E2E_Evaluator_vercel |
348254.9975037458 ns/iter |
352952.27965678857 ns/iter |
0.99 |
E2E_Evaluator_yamllint |
13627.872968243533 ns/iter |
14585.081932951167 ns/iter |
0.93 |
This comment was automatically generated by workflow using github-action-benchmark.
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
jviotti
force-pushed
the
non-circular-shared-refs
branch
from
48fea3d to
0db1303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com