Skip to content

Raise UnsupportedSyntax if a proc object is given as block-pass-argument #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tk0miya wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Raise UnsupportedSyntax if a proc object is given as block-pass-argument #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/steep/type_construction.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4191,6 +4191,16 @@ def try_method_type(node, receiver_type:, method_name:, method_overload:, argume
)
else
# non-nil value is given
if node_type.is_a?(AST::Types::Name::Instance) && node_type.name.to_s == '::Proc'

@tk0miya tk0miya Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better to move this into #synthesize?

errors << Diagnostic::Ruby::UnsupportedSyntax.new(
node: arg.node,
message: "Unsupported block-pass-argument given `#{node_type}`"
)

type = Interface::Function.new(params: nil, return_type: AST::Builtin.any_type, location: nil)
node_type = AST::Types::Proc.new(type: type, self_type: nil, block: nil)
end

constr.check_relation(sub_type: node_type, super_type: arg.node_type, constraints: constraints).else do |result|
errors << Diagnostic::Ruby::BlockTypeMismatch.new(
node: arg.node,
Expand Down
10 changes: 4 additions & 6 deletions smoke/block/test_expectations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,8 @@
character: 28
severity: ERROR
message: |-
Cannot pass a value of type `::Proc` as a block-pass-argument of type `^(::Integer) -> U(3)`
::Proc <: ^(::Integer) -> U(3)
code: Ruby::BlockTypeMismatch
Unsupported block-pass-argument given `::Proc`
code: Ruby::UnsupportedSyntax
- range:
start:
line: 11
Expand All @@ -116,9 +115,8 @@
character: 20
severity: ERROR
message: |-
Cannot pass a value of type `::Proc` as a block-pass-argument of type `^(::Integer) -> U(4)`
::Proc <: ^(::Integer) -> U(4)
code: Ruby::BlockTypeMismatch
Unsupported block-pass-argument given `::Proc`
code: Ruby::UnsupportedSyntax
- file: e.rb
diagnostics:
- range:
Expand Down
23 changes: 23 additions & 0 deletions test/type_construction_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7494,6 +7494,29 @@ def test_proc_with_block_annotation
end
end

def test_proc_for_block_pass_argument
with_checker() do |checker|
source = parse_ruby(<<-'RUBY')
# @type var f: Proc
f = _ = nil
r = [1, 2, 3].map(&f)
RUBY

with_standard_construction(checker, source) do |construction, typing|
type, _, context = construction.synthesize(source.node)

assert_typing_error(typing, size: 1) do |errors|
assert_any!(errors) do |error|
assert_instance_of Diagnostic::Ruby::UnsupportedSyntax, error
assert_equal "Unsupported block-pass-argument given `::Proc`", error.message
end
end
assert_equal parse_type("::Array[untyped]"), context.type_env[:r]
end
end
end


def test_next_with_next_type
with_checker(<<RBS) do |checker|
class NextTest
Expand Down