case/when record type narrowing - #1568
Open
HoneyryderChuck wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP to add type narrowing support for the following use-case:
@soutaro I'm needing some assistance on how to implement this. I'm looking at the type inference code, particularly the
CaseWhenstatement, but I'm not sure how to cleanly implement this. It seems that, when doingwhen_pats.add_pattern(pat) {|test, constr| constr.synthesize(test) }, the value forlvarshould be correctly inferred, but this annotation does not bubble up to thexfrom the case condition, which in the case statement is represented as as(:send, s(:lvar, :x), :[], s(:sym, :type)))node. My assumption is that the same limitation applies for the same method-call pattern, i.e. ifxwere declared asA | Band there was a methodfoowhich returns:fooforAand:barforB, the when block would not be able to distinguish between them.