Make steep query hover input 0-origin - #2215
Open
soutaro wants to merge 2 commits into
Open
Conversation
Input LINE:COL was documented as 1-based, but the range in the response JSON is 0-based (LSP convention). Align the CLI input to 0-based so input and output agree. The command is experimental and primarily used by coding agents, so matching the LSP convention is clearer. https://claude.ai/code/session_01CCWBNpki5VdxYv9yZdkJQj
Mirrors the CLI input change from 1-based to 0-based line/column. https://claude.ai/code/session_01CCWBNpki5VdxYv9yZdkJQj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input LINE:COL was documented as 1-based, but the range in the response
JSON is 0-based (LSP convention). Align the CLI input to 0-based so
input and output agree. The command is experimental and primarily used
by coding agents, so matching the LSP convention is clearer.
https://claude.ai/code/session_01CCWBNpki5VdxYv9yZdkJQj