Skip to content

feat(hw): add IR emitter quirk for Lenovo ThinkPad P14s Gen 4 (Syntek 174f:11a8) #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffshee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(hw): add IR emitter quirk for Lenovo ThinkPad P14s Gen 4 (Syntek 174f:11a8) #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions contrib/hw/174f-11a8.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
[device]
vendor_id = 0x174F
product_id = 0x11A8
name = "Lenovo ThinkPad P14s Gen 4 IR Camera (Syntek 174f:11a8)"

[emitter]
# UVC XU unit 14, selector 6, len 9: cur/def=[1,3,1] (off), max=[1,3,3] (on).
# Same control as 04f2-b6d0 / 30c9-0120; also found by linux-enable-ir-emitter.
unit = 14
selector = 6
control_bytes = [1, 3, 3, 0, 0, 0, 0, 0, 0]
# Rejects an all-zero "off" payload (ERANGE); the real off/default is [1,3,1,...].
off_bytes = [1, 3, 1, 0, 0, 0, 0, 0, 0]
3 changes: 3 additions & 0 deletions crates/visage-hw/src/quirks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ const QUIRK_174F_2454: &str = include_str!("../../../contrib/hw/174f-2454.toml")
const QUIRK_30C9_00C2: &str = include_str!("../../../contrib/hw/30c9-00c2.toml");
/// Compile-time embedded quirk for the HP OmniBook X Flip IR camera (Luxvisions 30c9:0120).
const QUIRK_30C9_0120: &str = include_str!("../../../contrib/hw/30c9-0120.toml");
/// Compile-time embedded quirk for the Lenovo ThinkPad P14s Gen 4 IR camera (Syntek 174f:11a8).
const QUIRK_174F_11A8: &str = include_str!("../../../contrib/hw/174f-11a8.toml");

static QUIRK_DB: OnceLock<Vec<QuirkFile>> = OnceLock::new();

Expand Down Expand Up @@ -68,6 +70,7 @@ const QUIRK_SOURCES: &[(&str, &str)] = &[
("174f-2454.toml", QUIRK_174F_2454),
("30c9-00c2.toml", QUIRK_30C9_00C2),
("30c9-0120.toml", QUIRK_30C9_0120),
("174f-11a8.toml", QUIRK_174F_11A8),
];

fn quirk_db() -> &'static Vec<QuirkFile> {
Expand Down
1 change: 1 addition & 0 deletions docs/hardware-compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ VID:PID to the correct control bytes for each known device.
| Lenovo ThinkPad X1 Carbon Gen 9 20XW00FPUS | `174f:2454` | ✅ Verified on hardware |
| Lenovo ThinkBook 14 MP2PQAZG | `30c9:00c2` | ✅ Verified on hardware |
| HP OmniBook X Flip | `30c9:0120` | ✅ Verified on hardware |
| Lenovo ThinkPad P14s Gen 4 21HF | `174f:11a8` | ✅ Verified on hardware |

**Known devices with NO quirk entry:**

Expand Down