feat(packaging): Fedora RPM via cargo-generate-rpm - #103
Open
jeffshee wants to merge 1 commit into
Open
Conversation
`cargo generate-rpm -p crates/visaged` now produces an RPM with the same assets as the .deb at Fedora's paths (PAM module in /usr/lib64/security). Fedora has no pam-auth-update and authselect owns system-auth, so PAM stays manual; the package ships the one-line snippet with the same [success=done default=ignore] control as the other packaging, and pam_control_contract checks that file too. Tested on Fedora 44 x86_64: build, dnf install and upgrade, sudo, polkit and GDM unlock via face. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Jeff Shee <jeffshee8969@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this solve?
There is no way to install Visage on Fedora except copying files by hand. The
.deblayoutputs the PAM module in
usr/lib/security, which is/usr/lib64/securityon Fedora, andFedora has no
pam-auth-update.Type
What this changes
[package.metadata.generate-rpm]on thevisagedcrate, socargo generate-rpm -p crates/visagedbuilds an RPM with the same assets as the.debat Fedora's paths. No newdependency for anyone not building the RPM.
packaging/rpm/visage.pam, installed to/usr/share/visage/pam.d/visage: the one-line PAMsnippet for the manual wiring Fedora needs, with the same
[success=done default=ignore]control as the Debian, Arch and NixOS packaging. Added to
pam_control_contractso it cannotdrift.
Testing
Fedora 44 x86_64, cargo-generate-rpm 0.20.0: build,
dnf install, upgrade over a previouslocal build,
systemctl enable --now, then face auth viasudo, polkit and GDM unlock.cargo test --workspacepasses including the extended contract test.Checklist
cargo fmt --all -- --checkpassescargo clippy --workspace -- -D warningspassescargo test --workspacepassesgit commit -s) per the DCO