Активные СЦП без игрока в теле - #1124
Open
666XxttimurkaxX666 wants to merge 2 commits into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughДобавлены HTN-конфигурации для SCP-999 и подключены HTN-компоненты с перемещением к SCP-131A, SCP-939 и SCP-999. Для SCP-247 изменена фракция на ChangesHTN-поведение SCP
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SCP999
participant Scp999Compound
participant NearbyHumanoidTarget
participant Movement
participant Speech
SCP999->>Scp999Compound: запуск HTN с постоянным перепланированием
Scp999Compound->>NearbyHumanoidTarget: поиск ближайшей доступной гуманоидной цели
NearbyHumanoidTarget-->>Scp999Compound: цель в зоне видимости
Scp999Compound->>Movement: следование к цели
Scp999Compound->>Speech: скрытая локализованная реплика после ожидания
Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Resources/Prototypes/_Scp/Entities/Mobs/NPCs/compound.yml`:
- Around line 68-71: В запросе ComponentQuery, используемом
Scp999FollowNearbyCompound и Scp096FollowNearbyCompound, удалите фильтр species:
Human, сохранив проверку только на компонент HumanoidAppearance, чтобы
выбирались ближайшие гуманоиды всех видов.
In `@Resources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp939.yml`:
- Around line 111-123: Update the HTN blackboard value for MeleeRange in the
SCP-939 configuration to 2 so it matches the weapon’s effective range; leave the
existing melee weapon range unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c2de0d01-ea35-47cd-a4eb-86fd58c68475
📒 Files selected for processing (6)
Resources/Prototypes/_Scp/Entities/Mobs/NPCs/compound.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp096.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp131.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp247.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp939.ymlResources/Prototypes/_Scp/Entities/Mobs/Player/Scp/Main/scp999.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Краткое описание
так сцп будут более реалистичными и живее
Ссылка на багрепорт/Предложение
Медиа (Видео/Скриншоты)
Changelog
🆑 timur
Summary by CodeRabbit