Fix occluder perf - #6940
Open
metalgearsloth wants to merge 2 commits into
Open
Conversation
Caches embedded lights andd fixeds allocs
DrSmugleaf
approved these changes
Aug 8, 2026
| { | ||
| foreach (var lightUid in _embeddedLightCache) | ||
| { | ||
| if (!_pointLightQuery.TryGetComponent(lightUid, out var light) || |
Contributor
There was a problem hiding this comment.
If this is already properly getting removed on ComponentRemove would it not be safe to store the component so you don't need to TryGet it here?
Contributor
Author
There was a problem hiding this comment.
Yeah.
TBH I may revisit this so gonna hold off on merging for now but handling all of the edge cases to drop shared edges is not great on client atm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caches embedded lights and fixed allocs