Fix Clyde deadlock on nvidia/wayland - #6966
Open
DamianX wants to merge 1 commit into
Open
Conversation
… fence deadlock on NVIDIA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not well-versed in OpenGL but I think this is correct.
According to the docs here:
We use WaitSync instead of ClientWaitSync, so I'm not sure how relevant that is, however the docs also say:
In our case, we do FenceSync here:
RobustToolbox/Robust.Client/Graphics/Clyde/Clyde.Rendering.cs
Line 1171 in 1d0b581
and then we WaitSync on it here:
RobustToolbox/Robust.Client/Graphics/Clyde/GLContext/GLContextWindow.cs
Line 206 in 1d0b581
And we don't Flush() at any point.
Additionally, Issue 20 in the docs also indicates a Flush() after FenceSync() is needed in this situation, which is what my change adds. It does still mention ClientWaitSync instead of WaitSync, and I'm not sure if that matters.
This change does fix the issue on my end so it closes #6958