Refactor Coordinate Frames#567
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 86.03% 86.16% +0.13%
==========================================
Files 27 38 +11
Lines 4045 4092 +47
==========================================
+ Hits 3480 3526 +46
- Misses 565 566 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
be55069 to
dfe79b4
Compare
dfe79b4 to
0c4ce1f
Compare
There was a problem hiding this comment.
Should this even be in coordinate_frames? It does not appear to be referenced anywhere inside it. It seems to actually be used only by the WCS so maybe move it into wcs._utils?
There was a problem hiding this comment.
@nden could answer this better, but it seems that while it is not directly related to coordinate frames, ucd/ctype is important for axes types that are, in turn, related to the coordinate frames. However, it does not seem to me that the location of this is of much importance, especially if private.
There was a problem hiding this comment.
I don't. Perhaps in the future there will be more need for coordinate_frames/utils but I can't think of anything right now. I'm fine if you want to move it.
| __all__ = ["Frame2D"] | ||
|
|
||
|
|
||
| class Frame2D(CoordinateFrame): |
|
LGTM. Can you run the regression tests for both pipelines? |
|
The regression tests indeed pass. |
This PR cleans up the
coordinate_framesmodule, splitting it into submodules and fully implementing type hints to describe its API.Note that this PR is built on #562 and #563 so those PRs should be merged first.