Clean up the internal calls in GWCS#696
Open
WilliamJamieson wants to merge 7 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
+ Coverage 86.13% 86.29% +0.15%
==========================================
Files 41 41
Lines 4349 4428 +79
==========================================
+ Hits 3746 3821 +75
- Misses 603 607 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
6 times, most recently
from
February 17, 2026 18:07
5bf1217 to
a930d24
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
2 times, most recently
from
February 19, 2026 19:13
5e1d55a to
829037f
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
2 times, most recently
from
March 18, 2026 13:29
d609d0d to
7d478b8
Compare
WilliamJamieson
marked this pull request as ready for review
March 18, 2026 18:41
Collaborator
Author
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
from
June 17, 2026 20:37
66c8dc7 to
44b2f19
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
2 times, most recently
from
July 8, 2026 16:30
8cbe570 to
3af7c08
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
from
July 15, 2026 22:27
3af7c08 to
b2afe08
Compare
… evaluate and invert
Need to handle Identity directly rather than trying to infer it.
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
3 times, most recently
from
July 16, 2026 20:01
a42e7d7 to
2bff14e
Compare
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
5 times, most recently
from
July 17, 2026 02:15
5df14a8 to
aed3232
Compare
mcara
reviewed
Jul 17, 2026
mcara
left a comment
mcara
left a comment
Member
There was a problem hiding this comment.
IMO, this is an epic refactor that consolidates the Native API call paths, improves consistency, and resolves the Quantity handling issues in the APE‑14 low‑level API. This looks good to me. However, regression tests should be re-run before formal approval.
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
from
July 17, 2026 15:00
aed3232 to
ee99c91
Compare
Fixes for 1. Inconsistencies in the API. 2. Backwards compatibility 3. Broken edge cases 4. Deprecation warnings for legacy code
WilliamJamieson
force-pushed
the
Refactor_internal_API
branch
from
July 17, 2026 16:28
ee99c91 to
443dddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the code call paths for the GWCS Native API use common code paths instead of effectively replicating code. This way the external API can be more properly expressed and maintained in a consistent fashion. Fix #561
As a byproduct of this work we also fix issues with quantities in the "APE 14 low-level API". Documentation of this will come in a follow on PR. Fix #689
Tasks
gwcstests.docs/page.no-changelog-entry-needed.)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types).News fragment change types:
changes/<PR#>.feature.rst: new featurechanges/<PR#>.breaking.rst: any change or deprecation of the public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.doc.rst: documentation changechanges/<PR#>.misc.rst: infrastructure or miscellaneous change