solves #726: bug in default inverse mapping#727
Conversation
sky2pix_proj can't access the __name__ attribute of the parent class, so explicitly access from the parent class.
|
I suppose tests added in #600 are missing the important block of code that was added in that PR, as well as Could you, please, update or add unit tests to cover this code? |
|
Also, you are using |
Oh sorry. I am still learning my way around Github, so this happened by mistake. Should I create a new feature branch, and then again create a pull request? Any suggestion is appreciated. |
|
This PR has been replaced by #729 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 41 41
Lines 4340 4340
=======================================
Hits 3723 3723
Misses 617 617 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This PR addresses a bug that triggered when a
backward_transformis not defined and defaultnumerical_inverseneeds to be used.Tasks
no-changelog-entry-neededNews fragment change types:
changes/727.bugfix.rst: fixes an issue