Skip to content

solves #726: bug in default inverse mapping #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0Navin0 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

solves #726: bug in default inverse mapping #729

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3173496
solves #726: bug in default inverse mapping
0Navin0 Mar 12, 2026
f1a0f32
Merge branch 'main' into fix-wcs-inverse
0Navin0 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions gwcs/wcs/_wcs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2763,14 +2763,14 @@ def _calc_approx_inv(self, max_inv_pix_error=5, inv_degree=None, npoints=16):
if isinstance(transform, projections.Projection):
sky2pix_proj = transform
break
if sky2pix_proj.__name__.startswith("Pix2Sky"):
if sky2pix_proj.__class__.__name__.startswith("pix2sky"):

@mcara mcara Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if sky2pix_proj.__class__.__name__.startswith("pix2sky"):
if type(sky2pix_proj).__name__.startswith("Pix2Sky")

sky2pix_proj = sky2pix_proj.inverse
lon_pole = _compute_lon_pole((crval1, crval2), sky2pix_proj)
ntransform = (
(Shift(crpix[0]) & Shift(crpix[1]))
| self.forward_transform
| RotateCelestial2Native(crval1, crval2, lon_pole)
| sky2pix_proj()
| sky2pix_proj
)

# standard sampling:
Expand Down