DOC: Complete API for white_light#10705
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10705 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 374 374
Lines 40349 40349
=======================================
Hits 35149 35149
Misses 5200 5200 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
emolter
left a comment
There was a problem hiding this comment.
Looks great, but a question about the expected input types.
It's sorta beyond the scope of this PR but at the same time should be fixed, and this was an opportunity to review the documentation.
Looks like you are one of the owners of this step. Just tell me what to change and I will change it. 😸 Line 83 in d626e4c |
|
Yeah fair enough. I think @melanieclarke will know best though as she implemented |
This comment was marked as resolved.
This comment was marked as resolved.
|
Ned is right -- this step only supports TSOMultiSpecModel now. Anywhere it says MultiSpecModel for this step, it should now say TSOMultiSpecModel. Thanks for catching that! |
as requested by Ned Molter and Melanie Clarke
594b0f1 to
e3d1000
Compare
|
Thanks @emolter and @melanieclarke ! I think I have addressed all comments. Please re-review to make sure I got them right. |
Towards JP-4107
This PR addresses
white_lightportion of #9793 . Only touch docs so should not need RT.On main:
With this patch:
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files