JP-4355: Move photom step after extract_1d step for WFSS modes#10718
Draft
emolter wants to merge 15 commits into
Draft
JP-4355: Move photom step after extract_1d step for WFSS modes#10718emolter wants to merge 15 commits into
emolter wants to merge 15 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10718 +/- ##
==========================================
- Coverage 87.11% 87.08% -0.03%
==========================================
Files 374 374
Lines 40320 40354 +34
==========================================
+ Hits 35123 35143 +20
- Misses 5197 5211 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
initial regression test attempt https://github.com/spacetelescope/RegressionTests/actions/runs/29605834306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-4355
This PR moves the photom step to occur after extract_1d for WFSS data.
Implications:
PhotomStepnow expectsWFSSMultiSpecModelas input.Extract1dStepnow goes through a different logical path for WFSS modes, and step output when run standalone will be in DN/s units.calwebb_spec2will remain identical within roughly numerical precision.calwebb_spec2will be in different units, since this product will no longer be flux-calibrated.Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files