Skip to content

switch check in elp to use result instead of model#2389

Merged
schlafly merged 1 commit into
spacetelescope:mainfrom
braingram:use_result
Jul 14, 2026
Merged

switch check in elp to use result instead of model#2389
schlafly merged 1 commit into
spacetelescope:mainfrom
braingram:use_result

Conversation

@braingram

@braingram braingram commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

While working on some related changes I noticed that the elp is accessing model (the input model, which may be closed) instead of result when checking the source_catalog sub-tree. This PR switches the access to use result. I don't think by itself the code on main can cause an issue with current asdf and roman_datamodels but it seems more correct to use result (and if we change how roman_datamodels handles a closed asdf file the code on main could be problematic).

Regression tests:
https://github.com/spacetelescope/RegressionTests/actions/runs/29345171004/job/87126875995

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks existing functionality, also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.82%. Comparing base (35c3dc2) to head (b565a0c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2389   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         131      131           
  Lines        7249     7249           
=======================================
  Hits         6004     6004           
  Misses       1245     1245           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@braingram
braingram marked this pull request as ready for review July 14, 2026 18:10
@braingram
braingram requested review from a team and ddavis-stsci as code owners July 14, 2026 18:10

@schlafly schlafly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks Brett.

@schlafly
schlafly merged commit 4536045 into spacetelescope:main Jul 14, 2026
24 checks passed
@braingram
braingram deleted the use_result branch July 14, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants