Add read pattern test.#2390
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2390 +/- ##
=======================================
Coverage 82.82% 82.82%
=======================================
Files 131 131
Lines 7249 7249
=======================================
Hits 6004 6004
Misses 1245 1245 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Remove redundant comment about regression test.
|
@braingram or @WilliamJamieson , any interest reviewing? This PR just adds a unit test that currently fails; when copying metadata into the source catalog or segmentation map from the L2 image, some array fields do not survive. This test demonstrates that problem. spacetelescope/roman_datamodels#692 intends to fix the issue. That does work; the regression test run |
|
Should we consider #2237 so we can compare the truth metadata to the regtest results? |
|
Ugh, sorry I lost #2237. Let me respond in the thread there about that one... |
This PR adds a new test to make sure that read_pattern is propagated into catalogs / segmentation maps. It is a nested arrays and so there is some roman_datamodels handling that can cause problems.
Only adds a unit test (which should fail). Regtests pointing to spacetelescope/roman_datamodels#692 should pass:
https://github.com/spacetelescope/RegressionTests/actions/runs/29610396350
Tasks
24Q4_B15(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/page