Conversation
kglidic
changed the title
kglidic
marked this pull request as ready for review
September 23, 2026 19:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
replace_nanswas updated to replace NaNs in the ERR array with a large bad value of 1e6 so that shifting would not turn the ERR array entirely into NaNs (#301). However, shifting those 1e6 values introduced distorted ERR values.In this PR, NaNs are left in the ERR array until
shift_frames. Inshift_frames, NaNs are temporarily replaced with 0, while a separate mask tracks their original locations and is shifted using the same offsets. After shifting, the affected ERR pixels are then set to 1e6.This closes #304
Additional things in this PR:
mask_NDsquaresfunction in imagetools.use_ta_issuesbranch.NIRCam Tutorial Data :
MIRI Tutorial Data :
