Fix #501: Use absolute URL for STScI logo in README#549
Conversation
|
I'm hesitant to say that removing the brandmark entirely is the best solution here |
|
Fair enough. I can switch the image src to an absolute raw URL so the brandmark renders on PyPI too: Want me to pin to a commit SHA instead of main so old releases don't break retroactively? Either way, I can update the PR. |
|
if we're going to point to a URL anyway then perhaps we should point to a central location in general PyPI readme rendering is important so I'll bring it up with our upcoming templating work |
e124367 to
92990a0
Compare
The relative path docs/_static/stsci_pri_combo_mark_white.png does not render on PyPI. Switch to an absolute raw.githubusercontent.com URL so the brandmark displays on both GitHub and PyPI.
92990a0 to
bd95198
Compare
|
Updated to keep the brandmark with an absolute |
There was a problem hiding this comment.
Pull request overview
This PR addresses PyPI README rendering by changing the README logo reference so it no longer depends on a relative path that breaks on PyPI.
Changes:
- Replaced the README logo
<img>srcfrom a relative path to an absoluteraw.githubusercontent.comURL.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The relative-path
imgtag (docs/_static/stsci_pri_combo_mark_white.png) renders on GitHub but breaks on PyPI. Switch to an absoluteraw.githubusercontent.comURL so the brandmark displays on both.Closes #501.