Fix astrometric distortion, cleanup code, and test better#150
Merged
Conversation
mperrin
force-pushed
the
fix_148_distortion
branch
from
June 10, 2026 17:45
2856648 to
05f350e
Compare
mperrin
force-pushed
the
fix_148_distortion
branch
from
June 12, 2026 19:37
05f350e to
5b86f16
Compare
Collaborator
Author
|
@kdlawson I'd like to tag you to review this PR, so I added you to the list of collaborators for the repo. Once you've accepted that invite I'll tag you as a reviewer here, or you ought to be able to add yourself as a reviewer too. |
mperrin
marked this pull request as ready for review
June 12, 2026 20:47
kdlawson
self-requested a review
June 17, 2026 14:16
kdlawson
approved these changes
Jun 17, 2026
kdlawson
left a comment
kdlawson
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me overall! I left a few minor comments/nits, but none are blocking.
…ed to include plot by default since it's not needed in CI
kdlawson
approved these changes
Jun 17, 2026
kdlawson
left a comment
kdlawson
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good to me, thanks! Ready to merge from my perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and improvements to the distortion code
distort_image. Remove unused parameters and code paths. Rename some variables to clearly indicate which are Ideal vs Science coordinate frames. Add more comments.