changing plot_date to plot due to matplotlib3.11 update#154
Merged
Conversation
marcio-melendez
approved these changes
Jun 30, 2026
marcio-melendez
left a comment
marcio-melendez
left a comment
Collaborator
There was a problem hiding this comment.
This works as intended without errors for matplotlib 3.11. Thanks for implementing this fix! Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to fix the bugs raised in #153.
plot_datehas been removed in Matplotlib 3.11. According to the documentation,plotnow works with datetime and numpy objects and can be replaced.Wherever
plot_datewas given in trending.py, I have replaced it withThis fix has been tested on both Matplotlib 3.11 and an earlier version of Matplotlib (3.10.9) and I confirmed that using plot produces the same results and is identical to the previous plot_date method in both versions of Matplotlib.