HLA-1587: Ignore distortion header keywords when comparing test WCS solutions #246
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves HLA-1587
Closes #
This PR addresses an issue arising from astropy PR #19228. That PR enables the ability to load a secondary WCS with that secondary's distortion correction. Since this is not something we regularly do, we can generally ignore this change as the primary distortion is almost always used for HST.
#19228 does change some code behavior in that when a secondary WCS solution is applied, the WCS solution will not have values for the header keywords
cpdis1orcpdis2.The astropy PR was causing one of our tests to fail
test_apply_as_alternate_methodbecause the test was looking to make sure all relevant header keywords were the same. Since thecpdiskeywords were None when applying a secondary, this was causing the failure. The solution is introduce aignore_cpdisargument for the tests applying a secondary.Checklist for maintainers
CHANGELOG.rstwithin the relevant release section