Allocate all four SH textures for paged ext splats - #424
Open
oscarlorentzon wants to merge 1 commit into
Open
Conversation
The ext encoding uploads four SH arrays for sh3 while the pager allocated three. A paged sh3 asset threw RangeError on every page upload and lost its SH3 term. Assets below sh3 and the packed path are unaffected.
Contributor
|
Nice find and fix! In the future we'll need to add some regression tests so this doesn't happen again. I'm wondering about removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading an asset with SH degree 3 throws
RangeError: offset is out of boundswhen bothpagedandpagedExtSplatsare on. It happens once for each page that has SH3 data in it. The page is left without one of its two SH3 textures, and the rest of that frame's loading is skipped, so the scene fills in slowly or not at all.pagedExtSplats, SH3 is stored in two textures instead of one, so an sh3 asset needs four SH textures where other assets need three. Only three were created, so the fourth upload had no texture to write into and failed.pagedExtSplats, work as before.