Support null MX and SRV records that use the root label - #125
Merged
Conversation
A null MX ("0 .", RFC 7505) and an SRV record that declines a service
("0 0 0 .", RFC 2782) carry the root label as their target. prepareDomain
rejected it because the dot-stripped root is an empty string, which the
Domain helper treats as a missing domain, so these valid records threw and
were silently dropped during parsing. Represent the root as an empty string,
consistent with how every other domain value is stored dot-stripped and has
its trailing dot re-appended by __toString. The query path stays strict.
mattiasgeniar
marked this pull request as draft
June 11, 2026 17:52
mattiasgeniar
marked this pull request as ready for review
June 11, 2026 19:11
Member
|
Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a null MX (RFC 7505) or a service-declining SRV (RFC 2782) threw
InvalidArgument::domainIsMissing, because the root label.was fed toDomainas an empty host. Both are valid records that appear in the wild:This PR allows the package to parse and round-trip them instead of rejecting them.