Skip to content

Remove the dependency on nette/utils#16

Merged
spaze merged 1 commit intomainfrom
spaze/nette/utils
Aug 22, 2025
Merged

Remove the dependency on nette/utils#16
spaze merged 1 commit intomainfrom
spaze/nette/utils

Conversation

@spaze
Copy link
Owner

@spaze spaze commented Aug 22, 2025

It is still required as a transitive dependency, though.

It is still required as a transitive dependency, though.
@spaze spaze requested a review from Copilot August 22, 2025 14:33
@spaze spaze self-assigned this Aug 22, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the direct dependency on nette/utils from the project by eliminating the use of Nette's SmartObject trait and manually implementing its event handling functionality. The change reduces external dependencies while maintaining the same functionality.

  • Removed nette/utils from composer.json dependencies
  • Replaced SmartObject trait usage with manual event handler implementation
  • Updated event invocation from magic method to explicit foreach loop

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/MysqlSessionHandler.php Removed SmartObject trait and manually implemented onBeforeDataWrite event handling
composer.json Removed nette/utils dependency from requirements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@spaze spaze merged commit f91d87d into main Aug 22, 2025
12 checks passed
@spaze spaze deleted the spaze/nette/utils branch August 22, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant