Conversation
It is still required as a transitive dependency, though.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the direct dependency on nette/utils from the project by eliminating the use of Nette's SmartObject trait and manually implementing its event handling functionality. The change reduces external dependencies while maintaining the same functionality.
- Removed
nette/utilsfrom composer.json dependencies - Replaced SmartObject trait usage with manual event handler implementation
- Updated event invocation from magic method to explicit foreach loop
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/MysqlSessionHandler.php | Removed SmartObject trait and manually implemented onBeforeDataWrite event handling |
| composer.json | Removed nette/utils dependency from requirements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is still required as a transitive dependency, though.