Merged
Conversation
Older nette/database (pre 3.2.4) used never return type for __get and in that case PHPStan returns "Call to function is_int() with never will always evaluate to true."
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades PHPStan analysis to the maximum level and adds type safety improvements. The changes focus on adding runtime type checking for database column values and improving array type annotations for better static analysis.
- Upgraded PHPStan from level 8 to level max for stricter static analysis
- Added runtime type validation for database columns with custom exception handling
- Improved array type annotations to be more precise about key-value relationships
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MysqlSessionHandler.php | Enhanced type safety with runtime checks and improved array type annotations |
| src/Exceptions/SessionColumnUnexpectedTypeException.php | New exception class for handling unexpected database column types |
| phpstan.neon | Upgraded PHPStan analysis level from 8 to max |
| composer.json | Updated nette/database minimum version requirement to 3.2.4 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also more precise array types and require nette/database 3.2.4