fix: support newer onnx-asr Nemo import path#633
Open
VooDisss wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
speachesfailed to start whenonnx-asr0.11+ was installed.Startup crashed while importing the Parakeet executor with:
ImportError: cannot import name 'NemoConformerTdt' from 'onnx_asr.models'The current code assumes
NemoConformerTdtis available from:onnx_asr.modelsThat is no longer true in newer
onnx-asrreleases, where the class is exposed from:onnx_asr.models.nemoWhat this changes
This patch keeps the existing import for older versions and adds a fallback for newer ones.
from onnx_asr.models import NemoConformerTdtfrom onnx_asr.models.nemo import NemoConformerTdtWhat this fixes
onnx-asrversions are installedonnx-asrjust to run the serverWhy this matters
This failure happens before the app is fully up, so users hit a hard startup error even if they are not actively using the Parakeet path.
The fallback keeps the change narrow and makes startup more tolerant of dependency drift.