Skip to content

Gate the Spectranet page commands behind BUILD_SPECTRANET - #75

Merged
desertkun merged 1 commit into
mainfrom
fix/spectranet-debugger-build
Aug 31, 2026
Merged

Gate the Spectranet page commands behind BUILD_SPECTRANET#75
desertkun merged 1 commit into
mainfrom
fix/spectranet-debugger-build

Conversation

@morozov

@morozov morozov commented Aug 30, 2026

Copy link
Copy Markdown
Member

#70 added the gdbserver remote commands spectranet-set-page and spectranet-set-pagein to gdbserver_remote_commands.c, which compiles regardless of BUILD_SPECTRANET. spectranet-set-page calls spectranet_map_page(), whose definition sits inside #ifdef BUILD_SPECTRANET in spectranet.c with no counterpart in the !BUILD_SPECTRANET stub block — so any Spectranet-off build (e.g. --without-pthread) fails to link:

gdbserver_remote_commands.c: undefined reference to `spectranet_map_page'

Fix: guard the two commands and their remote_commands[] entries with #ifdef BUILD_SPECTRANET, merged into the adjacent xfs-debug guard, so they are absent when Spectranet isn't built.

@desertkun
desertkun merged commit 7a92c6b into main Aug 31, 2026
2 checks passed
@desertkun

Copy link
Copy Markdown
Collaborator

Thanks, sorry for the mess

@desertkun
desertkun deleted the fix/spectranet-debugger-build branch August 31, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants