Move the asr-metrics dependencies into a 'extra' set of dependencies#108
Closed
JamesG-Speechmatics wants to merge 2 commits into
Closed
Move the asr-metrics dependencies into a 'extra' set of dependencies#108JamesG-Speechmatics wants to merge 2 commits into
JamesG-Speechmatics wants to merge 2 commits into
Conversation
Contributor
Author
This would be a nice to do but I don't have time to do it and test it for the different metrics scripts, it would be something like in the right places (the file where main() is defined I suppose). @dan-cochrane |
Contributor
|
Didn't see this PR @JamesG-Speechmatics, sorry about that. I'm happy to pick up some of those changes. |
Contributor
Author
|
Closing in favour of #122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing numpy and other large libraries is not necessary if only doing realtime speech recognition. This MR moves the dependencies of
asr_metricsinto a larger version of the package to be installed astodo: code in asr_metrics to fail gracefully on import error.
Because this is a breaking change for anyone who does use asr_metrics, the major version is bumped from 2 to 3.