Conversation
This commit updates the `sysinfo` dependency from `0.29.7` to `0.33.0` in `implants/Cargo.toml`. It also refactors the `eldritch-libprocess` and `eldritch-libsys` crates to align with the breaking changes introduced in `sysinfo` 0.30+, including: - Replacing `SystemExt`, `ProcessExt`, `UserExt` traits with direct struct methods. - Using `System::new_all()` instead of `System::new()` and explicit refreshes. - Using the new `Users` struct for user enumeration (as `System::users()` was removed/changed). - Updating usage of `Pid` (using `Pid::from_u32` or `Pid::from(usize)`). - Handling `OsString` returns for `cmd`, `environ`, `name` by converting to `String` (lossy). - Enabling `system` and `user` features for `sysinfo` in `Cargo.toml`. - Fixing `get_user` implementation to handle opaque `Uid`/`Gid` types by parsing their string representation as a workaround for existing integer-based logic. Build and tests passed for `eldritch-libprocess` and `eldritch-libsys`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
Updated
sysinfodependency to 0.33.0. Refactored code inimplants/lib/eldritch/stdlib/eldritch-libprocessandimplants/lib/eldritch/stdlib/eldritch-libsysto handle API changes (removal of traits, separation ofUsersstruct, newPidtype).PR created automatically by Jules for task 9038399766666714236 started by @KCarretto