[AI] Expand Test Coverage - eldritch-core/lexer#1784
Conversation
- Update `lexer.rs` to correctly parse strings and comments within f-string expressions.
- This allows for nested braces inside strings within f-expressions (e.g., `f"{ '}' }"`).
- Add `lexer_new_coverage.rs` with tests for:
- Nested braces in f-strings.
- Quotes containing braces in f-strings.
- Indentation edge cases.
- Multiline f-string expressions.
- Update `lexer_more_edges.rs` to handle "Unterminated string literal" error for unclosed f-expressions that consume outer delimiters.
- Ensure all tests pass and are stable.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
This PR improves the robustness of the Eldritch DSL lexer, specifically for f-string expressions. It fixes an issue where braces inside string literals within an f-string expression would prematurely close the expression. It also enables support for multiline f-string expressions (in triple-quoted strings) and comments within expressions. Comprehensive tests covering these edge cases have been added.
PR created automatically by Jules for task 10654004627378857133 started by @KCarretto