Merged
Conversation
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
KCarretto
previously approved these changes
Feb 15, 2026
Collaborator
KCarretto
left a comment
KCarretto
left a comment
There was a problem hiding this comment.
Main concern is with the NewSchema method, imo it'd be better to use a functional API to help keep this method manageable. Otherwise lgtm.
tavern/internal/graphql/resolver.go
Outdated
|
|
||
| // NewSchema creates a graphql executable schema. | ||
| func NewSchema(client *ent.Client, importer RepoImporter) graphql.ExecutableSchema { | ||
| func NewSchema(client *ent.Client, importer RepoImporter, builderCA *x509.Certificate, builderCAKey ed25519.PrivateKey) graphql.ExecutableSchema { |
Collaborator
There was a problem hiding this comment.
Semi-important change
Instead of adding more arguments here that will be passed as nil, nil in tests etc., let's use a functional API:
func NewSchema(client *ent.Client, importer RepoImporter, options ...func(*Resolver)) graphql.ExecutableSchema {
resolver := &Resolver{
client: client,
importer: importer,
}
for _, opt := range options {
opt(resolver)
}
// ...
}
Collaborator
Author
There was a problem hiding this comment.
Updated - lemme know if this is what you're thinking tho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #