[AI] Expand Test Coverage - eldritch-core/parser#1787
Conversation
This commit modifies `eldritch-core/src/parser/expr.rs` to enforce strict argument ordering in function calls, consistent with Python syntax. Specifically, it ensures that: - Positional arguments cannot follow keyword arguments. - Iterable argument unpacking (`*args`) cannot follow keyword arguments. If these rules are violated, the parser now returns a descriptive error. This behavior is verified by new tests in `eldritch-core/tests/parser_call_validation.rs`. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
Implemented strict argument ordering validation in
eldritch-coreparser for function calls.Added
seen_keyword_style_argflag infinish_callto track if keyword arguments or**kwargshave been encountered.If a positional argument or
*argsis encountered after a keyword argument, a syntax error is returned.Added
implants/lib/eldritch/eldritch-core/tests/parser_call_validation.rsto test valid and invalid call scenarios.Verified stability by running the new tests 20 times.
Ran regression tests for
eldritch-coreto ensure no side effects.PR created automatically by Jules for task 5210219499630704701 started by @KCarretto