Open
Conversation
* Add executor library with mock and Docker implementations Introduce an executor interface for build task execution with two implementations: MockExecutor for testing and DockerExecutor for production use. The Docker executor pulls the specified build image, runs the build script as the container entrypoint, and streams stdout/stderr over channels. The builder agent now passes claimed tasks to the executor, collects output/errors from channels, and reports results back to the server via gRPC. https://claude.ai/code/session_017WBbxwiwQS6tXTNcaBrfBH * cleanup --------- Co-authored-by: Claude <noreply@anthropic.com>
hulto
commented
Feb 11, 2026
- Extract poll interval magic number to taskPollInterval const - Simplify ClaimBuildTasks to follow beacon task claiming pattern (use rollback helper, reload tasks after commit, remove debug query) - Add rollback.go helper matching c2 package pattern - Add TODO section to README: concurrent builds, streaming tests, gRPC streaming for SubmitBuildTaskOutput Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
…ield type - Remove SetStartedAt from ClaimBuildTasks so claimed_at and started_at are distinct lifecycle stages (started_at should be set at execution time) - Update README with current gRPC API, executor docs, and full package table - Change BuildTask error field from String to Text for consistency with the output field and the Task schema pattern Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
Mirror the Task schema pattern: add output_size field with a HookDeriveBuildTaskInfo hook that auto-computes byte length from the output field on create/update. Enables sorting and filtering build tasks by output size in GraphQL. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
- Run build tasks concurrently with a semaphore (max 4) instead of sequentially blocking the poll loop. Wait for in-flight builds on context cancellation. - Invert channel ownership: executor implementations now close both outputCh and errorCh before returning (sender closes). This follows standard Go channel conventions and prevents fragile caller-side close ordering. - Make SubmitBuildTaskOutput idempotent: if a task is already finished, return success without overwriting. Handles network retries safely. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering>
hulto
commented
Feb 12, 2026
|
|
||
| // buildCommands maps (target_os, target_format) -> cargo build command. | ||
| var buildCommands = map[buildKey]string{ | ||
| {c2pb.Host_PLATFORM_LINUX, TargetFormatBin}: "cargo build --release --bin imix --target=x86_64-unknown-linux-musl", |
Collaborator
Author
There was a problem hiding this comment.
TargetFormatBin replace with Enum.
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #