Conversation
- Added `implants/lib/eldritch/eldritch-core/tests/fstrings_coverage.rs` with comprehensive tests for f-string interpolation, nested expressions, function calls, and edge cases.
- Modified `implants/lib/eldritch/eldritch-core/src/lexer.rs` to implement smarter brace counting in `tokenize_fstring_expression`. The lexer now correctly skips string literals (single and double quoted) when finding the end of an f-string expression, preventing premature termination when a closing brace appears inside a string literal (e.g., `f"{'}'}"`).
- Documented known limitation regarding multiline f-string expressions in the test file.
- Verified changes with 20 repeated runs of the new tests and a full regression run of `eldritch-core`.
Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
This PR expands the test coverage for the Eldritch DSL, specifically focusing on f-string expression parsing. It introduces a new test file
fstrings_coverage.rscovering various scenarios including nested expressions and edge cases.During testing, a bug was identified where
tokenize_fstring_expressionin the lexer naively counted braces without respecting string boundaries, causing expressions likef"{'}'}"to fail. This PR includes a fix for this issue by implementing a state-aware scan that skips string literals when counting braces.This addresses the goal of increasing test coverage and stability for high-complexity modules.
PR created automatically by Jules for task 2716521641508823385 started by @KCarretto