Conversation
- Added `implants/lib/eldritch/eldritch-core/tests/parser_call_validation.rs` to comprehensively test function call argument unpacking, ordering, and lambda edge cases. - Modified `implants/lib/eldritch/eldritch-core/src/parser/expr.rs` to enforce strict argument ordering: positional arguments cannot follow keyword arguments. - Verified all tests pass and are stable. Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 |
1 participant
This PR expands test coverage for
eldritch-coreby adding a new test suiteparser_call_validation.rsfocusing on function call argument unpacking (*args,**kwargs), lambda expressions, and argument ordering validation. It also fixes a parser permissiveness issue where positional arguments were allowed after keyword arguments, aligning behavior with standard Python syntax and improving DSL stability.PR created automatically by Jules for task 18062073430909605954 started by @KCarretto