Skip to content

[AI] Expand Test Coverage - dsl/parser#1806

Draft
KCarretto wants to merge 1 commit intomainfrom
ai-expand-test-coverage-dsl-parser-1602973022947213168
Draft

[AI] Expand Test Coverage - dsl/parser#1806
KCarretto wants to merge 1 commit intomainfrom
ai-expand-test-coverage-dsl-parser-1602973022947213168

Conversation

@KCarretto
Copy link
Collaborator

@KCarretto KCarretto commented Feb 14, 2026

Expanded test coverage for the eldritch-core parser, focusing on complex syntax and edge cases. Added tests/parser_coverage.rs and exported Expr in lib.rs to support the new tests. Verified stability by running tests 20 times.

PR created automatically by Jules for task 1602973022947213168 started by @KCarretto

@google-labs-jules @KCarretto
Add comprehensive tests for Eldritch DSL parser edge cases.
cc698d2 
This commit expands the test coverage for the `eldritch-core` parser by adding a new test file `parser_coverage.rs`. It includes tests for:
- Lambda expressions (basic, default args, *args)
- F-String nesting (e.g., set expressions inside f-strings)
- Extended comprehensions (Set and Dict)
- Complex slicing syntax
- Operator precedence
- Error recovery in list literals

Additionally, `eldritch-core/src/lib.rs` was updated to export `Expr` to allow tests to inspect the AST structure directly.

Co-authored-by: KCarretto <16250309+KCarretto@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Feb 14, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
2591    ±0 2591    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#965 ✅ 2591 2591 0 0 0 0 31.5s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
2591 0 0 5.2s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
eldritch-libsys: std::dll_inject_impl::tests::test_dll_inject_simple 1 5.2s 5.2s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: install::tests::test_install_execution 3 1.2s 3.4s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_output 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s
imix::bin/imix: tests::task_tests::test_task_streaming_error 3 3.0s 3.0s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@KCarretto