android: implement biometric authentication (fingerprint)#10340
android: implement biometric authentication (fingerprint)#10340SomberNight merged 3 commits intospesmilo:masterfrom
Conversation
SomberNight
left a comment
SomberNight
left a comment
There was a problem hiding this comment.
just some quick comments, I haven't really looked at this
f321x
force-pushed
the
fingerprint
branch
2 times, most recently
from
f724c33 to
3d72275
Compare
|
I assume this will be combined with #10339? (as handing over the wallet password to some biometric backend is a risk) |
|
@accumulator no, the PRs are independent. |
f321x
force-pushed
the
fingerprint
branch
2 times, most recently
from
f62cf83 to
0cf8b3c
Compare
|
this looks good to me, although I did not build an apk, |
|
running this apk for 2 weeks now, no issues so far |
f321x
force-pushed
the
fingerprint
branch
5 times, most recently
from
d3d7678 to
dac9e6a
Compare
|
Force pushed from 147e418 to dac9e6a. |
Allows to unlock the android app with the android biometric api (e.g. fingerprint). Can be enabled in the settings.
f321x
force-pushed
the
fingerprint
branch
2 times, most recently
from
7ddfd76 to
9f15a33
Compare
f321x
force-pushed
the
fingerprint
branch
4 times, most recently
from
9a76759 to
9e42c12
Compare
Completely removes the pin code authentication from qml. The config option in the wallet preferences has been renamed to "Payment authentication" and now either asks for the Android system authentication (Biometric or system pin/password) if enabled or will ask for the wallet password as fallback.
| if (Daemon.currentWallet.verifyPassword('')) { | ||
| // wallet has no password | ||
| qtobject.authProceed() | ||
| return | ||
| } |
There was a problem hiding this comment.
I guess this is a pre-existing issue, but shouldn't we call handleAuthConfirmationOnly instead?
There was a problem hiding this comment.
If the original call method was payment_auth yes we probably should (though wallets without password should be rare(?)). For wallet or wallet_password_only I don't think it would be useful.
There was a problem hiding this comment.
though wallets without password should be rare(?)
IIRC for several years, older versions of kivy did not allow setting a password for a watch-only wallet. So old installs, without password unification, could have those wallets still around.
Then again, if it's watch-only, not prompting for auth is not that critical.
4 participants
Allows to unlock the android app with the android biometric api (e.g. fingerprint). Can be enabled in the settings.
The initial version was LLM generated but i reviewed it and rewrote a couple things.
TODO: checkbox to enable it in the wizard during wallet setup once one password is enforced for creation of new wallets
closes #7560