Open
Conversation
f321x
changed the title
SomberNight
reviewed
Apr 11, 2026
Comment on lines
+239
to
+241
| if scheme == BITCOIN_BIP21_URI_SCHEME \ | ||
| or scheme == LIGHTNING_URI_SCHEME \ | ||
| or scheme in SUPPORTED_LNURL_SCHEMES: |
Member
There was a problem hiding this comment.
do we want to handle these URI schemes also in the desktop Qt GUI?
(related 016c8b5)
edit: "maybe later" is a sensible answer, just asking
Member
Author
LNURL-W/P can also be encoded in lud-17 form instead of bech32. https://github.com/lnurl/luds/blob/luds/17.md e.g. lnurlw://example.com/api/test123 lnurlp://example.com/api/test123
The RE_EMAIL and RE_DOMAIN regexes matched the '|' character which is probably not what they should do.
On install we register the URIs for bitcoin, lightning, lnurlp and lnurlw in the registry but on uninstall we would only remove bitcoin again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LNURL LUD-17 is an alternative scheme for lnurl urls which formats the urls in cleartext with a
lnurlX://scheme prefix instead of bech32 encoding them.Adding this is simple as we already support lnurl and makes Electrum compatible e.g. with Boltcards.