qml: ElTextArea default topPadding, hide placeholderText on input #10585
Draft
f321x wants to merge 2 commits intospesmilo:masterfrom
Draft
qml: ElTextArea default topPadding, hide placeholderText on input #10585f321x wants to merge 2 commits intospesmilo:masterfrom
f321x wants to merge 2 commits intospesmilo:masterfrom
Conversation
I noticed all ElTextAreas seem to look better with some topPadding, so it makes more sense to add it as default to ElTextArea. Followup to spesmilo#10579
When the user enters something into the ElTextArea the placeholder text should be hidden so it doesn't conflict with the user input. This affects e.g. the lnurl pay dialog.
Member
|
The current styling is basically Qt6.4 specific. I assume you run it locally with a higher Qt version? That would explain the wrong padding. |
Member
Author
|
@accumulator Ah yes, on current the Qt 6.4 Android build this padding issue actually doesn't exist. I noticed it on Qt 6.5 (Desktop QML) and on your Qt 6.10 branch, so we should probably have a look again after #10485 is merged, or you include it in #10485. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets a larger (than
padding) defaulttopPaddingon theElTextAreaas i noticed that all ElTextAreas look better with some more padding at the topFollowup to #10579
Also hides the
placeholderTextofElTextAreaas soon as the user enters something, otherwise it would conflict with the user input and look broken.E.g. lnurlpay dialog:
before:
after:
