wallet: make_unsigned_tx: fix base_tx for GUI simple-send batching#10591
Open
SomberNight wants to merge 1 commit intospesmilo:masterfrom
Open
wallet: make_unsigned_tx: fix base_tx for GUI simple-send batching#10591SomberNight wants to merge 1 commit intospesmilo:masterfrom
SomberNight wants to merge 1 commit intospesmilo:masterfrom
Conversation
fixes regression from spesmilo@a9f20e4 : For the GUI / manual new tx constructions usecase, the flow relies on `base_tx.add_info_from_wallet(self)` being called before `base_tx_fee = base_tx.get_fee()`. fixes spesmilo#10587 maybe fixes spesmilo#8876 probably not a full fix: base_tx could have inputs for which add_info_from_wallet is not sufficient
SomberNight
added
the
topic-wallet 👛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes regression from a9f20e4 : For the GUI / manual new tx constructions usecase, the flow relies on
base_tx.add_info_from_wallet(self)being called beforebase_tx_fee = base_tx.get_fee().