wallet_db: put 'genesis_blockhash' in DB, detect mainnet/testnet mixup. (db upgrade)#10592
Open
SomberNight wants to merge 2 commits intospesmilo:masterfrom
Open
wallet_db: put 'genesis_blockhash' in DB, detect mainnet/testnet mixup. (db upgrade)#10592SomberNight wants to merge 2 commits intospesmilo:masterfrom
SomberNight wants to merge 2 commits intospesmilo:masterfrom
Conversation
If the user tries to open a wallet for a different chain (mainnet vs testnet), try to show a reasonable error message. See previous attempt at this: spesmilo@c13e057, which added `wallet.test_addresses_sanity()`. However there are many codepaths where "random" exceptions might get raised before the Wallet object is even instantiated. See [discussion there](spesmilo@c13e057#commitcomment-28017341): > should we actually fix that? > if yes, it would be better to write the network type in storage Indeed now I think we should do that. At the time I was concerned it would not help against altcoin forks if we put "mainnet" or "testnet" in the DB. Now I realise we should just put the genesis block hash in the DB instead. Many of the reports in spesmilo#6526 are likely due to users trying to open a mainnet wallet in testnet mode or vice-versa. fixes spesmilo#9134 same issue in wizard 2fa two-step wallet-creation flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user tries to open a wallet for a different chain (mainnet vs testnet), try to show a reasonable error message.
See previous attempt at this: c13e057, which added
wallet.test_addresses_sanity(). However there are many codepaths where "random" exceptions might get raised before the Wallet object is even instantiated.See discussion there:
Indeed now I think we should do that. At the time I was concerned it would not help against altcoin forks if we put "mainnet" or "testnet" in the DB. Now I realise we should just put the genesis block hash in the DB instead.