Handle unfunded zeroconf channels in update_unfunded_state#9590
Merged
ecdsa merged 1 commit intospesmilo:masterfrom Mar 7, 2025
Merged
Handle unfunded zeroconf channels in update_unfunded_state#9590ecdsa merged 1 commit intospesmilo:masterfrom
ecdsa merged 1 commit intospesmilo:masterfrom
Conversation
ecdsa
reviewed
Mar 7, 2025
ecdsa
reviewed
Mar 7, 2025
f321x
force-pushed
the
jit-update-unfunded-state
branch
from
34cd7d2 to
5995299
Compare
f321x
force-pushed
the
jit-update-unfunded-state
branch
from
5995299 to
6fd833c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds handling of zeroconf channels with funding tx height
TX_HEIGHT_LOCAL. This way the client removes channels if the LSP fails to broadcast the funding transaction instead of trying to continue using it. It also allows the LSP to remove the channel on client side by sending shutdown instead of broadcasting the funding tx, the client will then remove the channel as it is inCLOSINGstate, this is useful if the LSP wants to abort the opening procedure, e.g. if the client fails to provide the preimage.Required for #9584