Check confirmed zeroconf channel funding address and amount#9624
Merged
ecdsa merged 1 commit intospesmilo:masterfrom Mar 13, 2025
Merged
Check confirmed zeroconf channel funding address and amount#9624ecdsa merged 1 commit intospesmilo:masterfrom
ecdsa merged 1 commit intospesmilo:masterfrom
Conversation
2d47b39 to
16dfb81
Compare
16dfb81 to
7a6b4ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
update_unfunded_stateso it checks the funding address and funding amount of a zeroconf channel once it has confirmations, so the client notices if the values differ from those negotiated in the channel establishment flow.Related to #9584