Fix Python executemany fallback rowcount aggregation - #57
Merged
Conversation
Copilot created this pull request from a session on behalf of
sphildreth
June 30, 2026 12:44
View session
sphildreth
marked this pull request as ready for review
June 30, 2026 12:44
sphildreth
approved these changes
Jun 30, 2026
There was a problem hiding this comment.
Pull request overview
Fixes Python DB-API Cursor.executemany() fallback behavior so Cursor.rowcount reflects the total affected rows across the entire batch (rather than only the last executed row). This aligns fallback execution with the optimized batch paths and typical DB-API expectations, unblocking Python binding suite coverage around batch inserts (e.g., all-NULL and Decimal).
Changes:
- Accumulate affected rows during fallback
executemany()by summingddb_stmt_affected_rows()after eachstep. - Set
self.rowcountfor non-query fallback execution to the aggregated total.
Comment on lines
+2832
to
+2838
| def fetch_affected_rows(params): | ||
| affected = ctypes.c_uint64() | ||
| code = self._lib.ddb_stmt_affected_rows(self._stmt, ctypes.byref(affected)) | ||
| if code != err_ok: | ||
| _raise_error(code, sql=sql, params=params) | ||
| return int(affected.value) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow failed in the Python binding suite because
Cursor.executemany()reportedrowcountfrom only the final row when the generic fallback path was used. This broke newly added coverage for all-NULLandDecimalbatch inserts that expect aggregate affected rows.What changed
executemanyexecution path inbindings/python/decentdb/__init__.pyto accumulate affected rows per executed row instead of reading only the final statement’s affected count.step, then summed intototal_affected.self.rowcountfor non-query fallback execution from the accumulated total.Behavioral impact
Cursor.rowcountnow reflects total rows processed across the entire fallback batch, aligning fallback behavior with fast batch paths and DB-API expectations.